From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V7 2/2] csky: remove irq_mapping from smp.c. Date: Mon, 24 Sep 2018 22:23:14 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Guo Ren Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Mark Rutland , Rob Herring , Stephen Rothwell , Linux Kernel Mailing List , DTML , linux-arch , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Greentime Hu List-Id: linux-arch.vger.kernel.org On Tue, Sep 18, 2018 at 3:48 PM Guo Ren wrote: > > - remove irq_mapping from smp.c to irq-driver > - Add set_ipi_irq_mapping api to irq-driver > - update asm/smp.h > > Signed-off-by: Guo Ren The patch seems ok to me, but please try to improve the changelog comments. Generally speaking, use full English sentences instead of an enumerated list, and explain what the change is for rather than what you are doing. The text you have here can easily be derived from looking at the code changes, but I still don't understand what caused you to change it, and why this is better than the previous version. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f195.google.com ([209.85.160.195]:45917 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbeIYC11 (ORCPT ); Mon, 24 Sep 2018 22:27:27 -0400 MIME-Version: 1.0 References: In-Reply-To: From: Arnd Bergmann Date: Mon, 24 Sep 2018 22:23:14 +0200 Message-ID: Subject: Re: [PATCH V7 2/2] csky: remove irq_mapping from smp.c. Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Guo Ren Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Mark Rutland , Rob Herring , Stephen Rothwell , Linux Kernel Mailing List , DTML , linux-arch , c-sky_gcc_upstream@c-sky.com, gnu-csky@mentor.com, Greentime Hu Message-ID: <20180924202314.w_OuF26ereYcy7Xx40Ts7WaWMJ17t4bNgbePYawlDp4@z> On Tue, Sep 18, 2018 at 3:48 PM Guo Ren wrote: > > - remove irq_mapping from smp.c to irq-driver > - Add set_ipi_irq_mapping api to irq-driver > - update asm/smp.h > > Signed-off-by: Guo Ren The patch seems ok to me, but please try to improve the changelog comments. Generally speaking, use full English sentences instead of an enumerated list, and explain what the change is for rather than what you are doing. The text you have here can easily be derived from looking at the code changes, but I still don't understand what caused you to change it, and why this is better than the previous version. Arnd