From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,URIBL_RED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07ACFC433B4 for ; Sat, 8 May 2021 11:38:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D055861430 for ; Sat, 8 May 2021 11:38:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230257AbhEHLjy (ORCPT ); Sat, 8 May 2021 07:39:54 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:35923 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbhEHLjx (ORCPT ); Sat, 8 May 2021 07:39:53 -0400 Received: from mail-wr1-f45.google.com ([209.85.221.45]) by mrelayeu.kundenserver.de (mreue011 [213.165.67.97]) with ESMTPSA (Nemesis) id 1Mk0e8-1lHEtG30BM-00kRTx; Sat, 08 May 2021 13:38:50 +0200 Received: by mail-wr1-f45.google.com with SMTP id d4so11774690wru.7; Sat, 08 May 2021 04:38:50 -0700 (PDT) X-Gm-Message-State: AOAM530oiKh2MMZczvHPrNgu7fSD+VN8zO5/lSTjR/pBiVVMXua+ZRzY C/AmWmvTiLYcNz1zJIw1OVqQuDEXioGgwqqzRhU= X-Google-Smtp-Source: ABdhPJz9Ugr0PcKykwE/hh6B427vWc6utZRdX8QIU/0Cr6kUxmxhdoRfUEI4Usf4M2X1Uz94Uu4T5nd0trDb5rVyhQE= X-Received: by 2002:a5d:4452:: with SMTP id x18mr19275744wrr.286.1620473930435; Sat, 08 May 2021 04:38:50 -0700 (PDT) MIME-Version: 1.0 References: <20210507220813.365382-1-arnd@kernel.org> <20210507220813.365382-7-arnd@kernel.org> In-Reply-To: <20210507220813.365382-7-arnd@kernel.org> From: Arnd Bergmann Date: Sat, 8 May 2021 13:38:01 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC 06/12] asm-generic: unaligned: remove byteshift helpers To: linux-arch Cc: Linus Torvalds , Vineet Gupta , Russell King , Nathan Chancellor , Nick Desaulniers , Linux ARM , Linux Kernel Mailing List , clang-built-linux Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:XIlD8vjJ1W0rLa4aosdkuaHT/wJ+yPvLA/7TDScMAiGnUZCyqxh +4KaoW2vz/TF7k2wlKZzm3p11YXDyOVX4jRAGtHWRTx8gbLBN3cegyQV6C2YZUhGysY6F7S R9CCRYlLsOT3MCa5bSxIlUrffruSigXnSNMBYiFF+lBocA1ukt0JFo6oDEGUgL6gHJPdDeH i0C7zbtIlQybllb1Z0SYA== X-UI-Out-Filterresults: notjunk:1;V03:K0:0bghlFN1rqo=:xGxxNCBXGlDvRQFCULRRjW rs0RgZTUzaY6c7wXv3Gwe8HCYsAMC3JIY1eGN2kTkt4DMtmSSJJ4UcZApHv0xtIhlOnknQx4Z NE2Hbs5vH0YI+GfqBA/cLKR1881YRlsctcsCtFbaVhJXtgjB17wo3GZE54eWgDLU8N68XWmLE lD8AbcvnppxzP8p3yGaNKEJ3PMNx0dTdbHHM6Zd5Y2PzI1uZNQ75jZs5TPdVYVHRj8PWNedJx 8cmZZ3JZJTs6/yyLQbshZYXsdCvaWj+3FRyXGfHW5xQLkKMkXbCJo4cgXxx29D/1yjh9ys5xz n+mM+Y+fjkteLNpWFckp9N8KPiGTcHsO+CQ/NdGYl2thZwjyOzci5eZwA7THLB5W90UZZpL8S Vjk6stl+lpJhQHkir5iteuy8P9t5jlLnmVQahxfVS0Gx6vgmKP1riQXQP8vjwDRZo9YS85w80 he+zGIv9cjMV19FfmdLX5MeWO3PYjQCiHOQROhZ/Z5o1/CTmozPEzlPzWTqtHAsEotg/6rtC8 w5qOv2kWcQ6wBLseEcMyRY= Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Sat, May 8, 2021 at 12:11 AM Arnd Bergmann wrote: > > Suggested-by: Linus Torvalds > Signed-off-by: Arnd Bergmann > --- > I've included this patch in the series because Linus asked about > removing the byteshift version, but after trying it out, I'd > prefer to drop this and use the byteshift version for the > generic code as well. Update: I've tried to create a small test case that illustrates the problem with using the swab() based version, however all cases combinations I tried showed either both producing identical output, or the shift version being worse, see https://godbolt.org/z/bTdsjnjfT I'll rewrite the patch description accordingly and leave this in place. Arnd