From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 5/5] m68k: add __IGNORE* entries in asm/unistd.h Date: Mon, 1 Oct 2018 14:51:59 +0200 Message-ID: References: <1538397477-4003-1-git-send-email-firoz.khan@linaro.org> <1538397477-4003-6-git-send-email-firoz.khan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1538397477-4003-6-git-send-email-firoz.khan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org To: Firoz Khan Cc: Geert Uytterhoeven , linux-m68k , gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz List-Id: linux-arch.vger.kernel.org On Mon, Oct 1, 2018 at 2:39 PM Firoz Khan wrote: > > Add __IGNORE* entries for seccomp, pkey_mprotect, pkey_ > alloc, pkey_free, io_pgetevents and rseq in the file > asm/unistd.h as it is correct to keep __IGNORE* entry in > non uapi header asm/unistd.h while uapi/asm/unistd.h must > hold information only useful for user space applications. > > Signed-off-by: Firoz Khan > --- > arch/m68k/include/asm/unistd.h | 7 +++++++ > 1 file changed, 7 insertions(+) I think this one needs to be dropped, as I commented on a similar patch for another architecture (I forget which one). We really should implemente all the syscalls below, with the possible exception of the pkey calls. Note that we even list pkey_* in architectures that don't support the feature. See also the commit text for a60f7b69d92c ("generic syscalls: Wire up memory protection keys syscalls") Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f68.google.com ([209.85.167.68]:34228 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729189AbeJAT37 (ORCPT ); Mon, 1 Oct 2018 15:29:59 -0400 MIME-Version: 1.0 References: <1538397477-4003-1-git-send-email-firoz.khan@linaro.org> <1538397477-4003-6-git-send-email-firoz.khan@linaro.org> In-Reply-To: <1538397477-4003-6-git-send-email-firoz.khan@linaro.org> From: Arnd Bergmann Date: Mon, 1 Oct 2018 14:51:59 +0200 Message-ID: Subject: Re: [PATCH v3 5/5] m68k: add __IGNORE* entries in asm/unistd.h Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Firoz Khan Cc: Geert Uytterhoeven , linux-m68k , gregkh , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038 Mailman List , Linux Kernel Mailing List , linux-arch , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20181001125159.Z8xCZnUcNZs0jFHE1W3mzSV5YSkGWqi0ZCYZm2qJKH4@z> On Mon, Oct 1, 2018 at 2:39 PM Firoz Khan wrote: > > Add __IGNORE* entries for seccomp, pkey_mprotect, pkey_ > alloc, pkey_free, io_pgetevents and rseq in the file > asm/unistd.h as it is correct to keep __IGNORE* entry in > non uapi header asm/unistd.h while uapi/asm/unistd.h must > hold information only useful for user space applications. > > Signed-off-by: Firoz Khan > --- > arch/m68k/include/asm/unistd.h | 7 +++++++ > 1 file changed, 7 insertions(+) I think this one needs to be dropped, as I commented on a similar patch for another architecture (I forget which one). We really should implemente all the syscalls below, with the possible exception of the pkey calls. Note that we even list pkey_* in architectures that don't support the feature. See also the commit text for a60f7b69d92c ("generic syscalls: Wire up memory protection keys syscalls") Arnd