From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: Ian Abbott <abbotti@mev.co.uk>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Nazarewicz <mina86@mina86.com>,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
Borislav Petkov <bp@suse.de>,
Johannes Berg <johannes.berg@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH 1/1] bug: fix problem including <linux.bug.h> from linux/kernel.h
Date: Wed, 24 May 2017 15:37:59 +0200 [thread overview]
Message-ID: <CAKwiHFgm2AmSmcWPO+-apH+7SW9Mjh_-jRUNepdx5FUiWukGRQ@mail.gmail.com> (raw)
In-Reply-To: <20170524132107.6919-2-abbotti@mev.co.uk>
On 24 May 2017 at 15:21, Ian Abbott <abbotti@mev.co.uk> wrote:
> If "include/linux/kernel.h" includes <linux/bug.h>, a circular
> dependency is introduced
Then don't. Can't we just create linux/build_bug.h and have that
contain the BUILD_BUG related macros - they're really completely
unrelated to all the asm-cruft bug.h needs to know about. build_bug.h
can then include compiler.h and not much else to figure out how it may
implement its macros. Then kernel.h can include build_bug.h, and we
don't force each and every translation unit to include bug.h and
everything that then pulls in. We just got rid of a lot of header
bloat, let's try to keep it that way.
Rasmus
next prev parent reply other threads:[~2017-05-24 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 13:21 [PATCH 0/1] bug: fix problem including <linux.bug.h> from linux/kernel.h Ian Abbott
2017-05-24 13:21 ` [PATCH 1/1] " Ian Abbott
2017-05-24 13:21 ` Ian Abbott
2017-05-24 13:37 ` Rasmus Villemoes [this message]
2017-05-24 15:55 ` Ian Abbott
2017-05-24 16:06 ` [PATCH v2] bug: fix problem including <linux/bug.h> " Ian Abbott
2017-05-24 23:11 ` Ian Abbott
2017-05-24 23:26 ` kbuild test robot
2017-05-24 23:26 ` kbuild test robot
2017-05-24 23:53 ` kbuild test robot
2017-05-24 23:53 ` kbuild test robot
2017-05-25 2:25 ` [PATCH 1/1] bug: fix problem including <linux.bug.h> " kbuild test robot
2017-05-25 2:25 ` kbuild test robot
2017-05-25 2:47 ` kbuild test robot
2017-05-25 2:47 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKwiHFgm2AmSmcWPO+-apH+7SW9Mjh_-jRUNepdx5FUiWukGRQ@mail.gmail.com \
--to=linux@rasmusvillemoes.dk \
--cc=abbotti@mev.co.uk \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@suse.de \
--cc=glider@google.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=johannes.berg@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).