From: Andy Lutomirski <luto@amacapital.net>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Brian Gerst <brgerst@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nadav Amit <nadav.amit@gmail.com>,
Kees Cook <keescook@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jann Horn <jann@thejh.net>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>, X86 ML <x86@kernel.org>
Subject: Re: [PATCH v2 05/13] mm: Move memcg stack accounting to account_kernel_stack
Date: Mon, 20 Jun 2016 09:05:24 -0700 [thread overview]
Message-ID: <CALCETrUhiFdNeE8BOcOYPDVLcDO6aq412iDT+Lf_9QHdmsY6Eg@mail.gmail.com> (raw)
In-Reply-To: <20160620130232.GC9892@dhcp22.suse.cz>
On Jun 20, 2016 6:02 AM, "Michal Hocko" <mhocko@kernel.org> wrote:
>
> On Fri 17-06-16 13:00:41, Andy Lutomirski wrote:
> > We should account for stacks regardless of stack size. Move it into
> > account_kernel_stack.
> >
> > Fixes: 12580e4b54ba8 ("mm: memcontrol: report kernel stack usage in cgroup2 memory.stat")
> > Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Michal Hocko <mhocko@kernel.org>
> > Cc: linux-mm@kvack.org
> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
This needs the same kilobyte treatment as the other accounting patch,
so I'm going to send v3 without your ack.
--Andy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@amacapital.net>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Brian Gerst <brgerst@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Nadav Amit <nadav.amit@gmail.com>,
Kees Cook <keescook@chromium.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jann Horn <jann@thejh.net>,
Vladimir Davydov <vdavydov@virtuozzo.com>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>, X86 ML <x86@kernel.org>
Subject: Re: [PATCH v2 05/13] mm: Move memcg stack accounting to account_kernel_stack
Date: Mon, 20 Jun 2016 09:05:24 -0700 [thread overview]
Message-ID: <CALCETrUhiFdNeE8BOcOYPDVLcDO6aq412iDT+Lf_9QHdmsY6Eg@mail.gmail.com> (raw)
Message-ID: <20160620160524.dSDUcCCqw8uh4Boi3IpCFjbjNOBqcNhspwvGidb1rq8@z> (raw)
In-Reply-To: <20160620130232.GC9892@dhcp22.suse.cz>
On Jun 20, 2016 6:02 AM, "Michal Hocko" <mhocko@kernel.org> wrote:
>
> On Fri 17-06-16 13:00:41, Andy Lutomirski wrote:
> > We should account for stacks regardless of stack size. Move it into
> > account_kernel_stack.
> >
> > Fixes: 12580e4b54ba8 ("mm: memcontrol: report kernel stack usage in cgroup2 memory.stat")
> > Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Michal Hocko <mhocko@kernel.org>
> > Cc: linux-mm@kvack.org
> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
This needs the same kilobyte treatment as the other accounting patch,
so I'm going to send v3 without your ack.
--Andy
next prev parent reply other threads:[~2016-06-20 16:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 20:00 [PATCH v2 00/13] Virtually mapped stacks with guard pages (x86, core) Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 01/13] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 02/13] x86/cpa: In populate_pgd, don't set the pgd entry until it's populated Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 03/13] x86/cpa: Warn if kernel_unmap_pages_in_pgd is used inappropriately Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:30 ` Borislav Petkov
2016-06-18 10:29 ` Andy Lutomirski
2016-06-18 10:29 ` Andy Lutomirski
2016-06-18 10:37 ` Borislav Petkov
2016-06-18 10:37 ` Borislav Petkov
2016-06-17 20:00 ` [PATCH v2 04/13] mm: Track NR_KERNEL_STACK in KiB instead of number of stacks Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-20 13:16 ` Michal Hocko
2016-06-20 13:16 ` Michal Hocko
2016-06-17 20:00 ` [PATCH v2 05/13] mm: Move memcg stack accounting to account_kernel_stack Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:55 ` Josh Poimboeuf
2016-06-17 22:18 ` Andy Lutomirski
2016-06-20 13:02 ` Michal Hocko
2016-06-20 13:02 ` Michal Hocko
2016-06-20 16:05 ` Andy Lutomirski [this message]
2016-06-20 16:05 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 06/13] fork: Add generic vmalloced stack support Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:57 ` Josh Poimboeuf
2016-06-17 20:57 ` Josh Poimboeuf
2016-06-17 22:18 ` Andy Lutomirski
2016-06-17 22:18 ` Andy Lutomirski
2016-06-20 13:36 ` Michal Hocko
2016-06-20 13:36 ` Michal Hocko
2016-06-20 16:13 ` Andy Lutomirski
2016-06-20 16:13 ` Andy Lutomirski
2016-06-21 8:46 ` Michal Hocko
2016-06-21 17:01 ` Andy Lutomirski
2016-06-21 17:01 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 07/13] x86/die: Don't try to recover from an OOPS on a non-default stack Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 08/13] x86/dumpstack: When OOPSing, rewind the stack before do_exit Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 09/13] x86/dumpstack: When dumping stack bytes due to OOPS, start with regs->sp Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 11/13] x86/dumpstack/64: Handle faults when printing the "Stack:" part of an OOPS Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 12/13] x86/mm/64: Enable vmapped stacks Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
2016-06-17 20:00 ` [PATCH v2 13/13] x86/mm: Improve stack-overflow #PF handling Andy Lutomirski
2016-06-17 20:00 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrUhiFdNeE8BOcOYPDVLcDO6aq412iDT+Lf_9QHdmsY6Eg@mail.gmail.com \
--to=luto@amacapital.net \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jann@thejh.net \
--cc=jpoimboe@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=nadav.amit@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov@virtuozzo.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).