From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Lutomirski Subject: Re: [PATCH 2/5] x86/fpu/xstate: Change some names to separate XSAVES system and user states Date: Thu, 7 Jun 2018 08:38:47 -0700 Message-ID: References: <20180607143544.3477-1-yu-cheng.yu@intel.com> <20180607143544.3477-3-yu-cheng.yu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180607143544.3477-3-yu-cheng.yu@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Yu-cheng Yu Cc: LKML , linux-doc@vger.kernel.org, Linux-MM , linux-arch , X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "H. J. Lu" , "Shanbhogue, Vedvyas" , "Ravi V. Shankar" , Dave Hansen , Jonathan Corbet , Oleg Nesterov , Arnd Bergmann , mike.kravetz@oracle.com List-Id: linux-arch.vger.kernel.org On Thu, Jun 7, 2018 at 7:40 AM Yu-cheng Yu wrote: > > To support XSAVES system states, change some names to distinguish > user and system states. > > Change: > supervisor to system > copy_init_fpstate_to_fpregs() to copy_init_fpstate_user_settings_to_fpregs() > xfeatures_mask to xfeatures_mask_user > XCNTXT_MASK to SUPPORTED_XFEATURES_MASK (states supported) How about copy_init_user_fpstate_to_fpregs()? It's shorter and more to the point. --Andy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:45156 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934869AbeFGPjA (ORCPT ); Thu, 7 Jun 2018 11:39:00 -0400 Received: from mail-io0-f180.google.com (mail-io0-f180.google.com [209.85.223.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12CEB2089B for ; Thu, 7 Jun 2018 15:39:00 +0000 (UTC) Received: by mail-io0-f180.google.com with SMTP id s26-v6so12337163ioj.4 for ; Thu, 07 Jun 2018 08:39:00 -0700 (PDT) MIME-Version: 1.0 References: <20180607143544.3477-1-yu-cheng.yu@intel.com> <20180607143544.3477-3-yu-cheng.yu@intel.com> In-Reply-To: <20180607143544.3477-3-yu-cheng.yu@intel.com> From: Andy Lutomirski Date: Thu, 7 Jun 2018 08:38:47 -0700 Message-ID: Subject: Re: [PATCH 2/5] x86/fpu/xstate: Change some names to separate XSAVES system and user states Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yu-cheng Yu Cc: LKML , linux-doc@vger.kernel.org, Linux-MM , linux-arch , X86 ML , "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "H. J. Lu" , "Shanbhogue, Vedvyas" , "Ravi V. Shankar" , Dave Hansen , Jonathan Corbet , Oleg Nesterov , Arnd Bergmann , mike.kravetz@oracle.com Message-ID: <20180607153847.dbgxdTF4c4tAiQHDISIKF_ekMn3v_JskADopJ15z2Gc@z> On Thu, Jun 7, 2018 at 7:40 AM Yu-cheng Yu wrote: > > To support XSAVES system states, change some names to distinguish > user and system states. > > Change: > supervisor to system > copy_init_fpstate_to_fpregs() to copy_init_fpstate_user_settings_to_fpregs() > xfeatures_mask to xfeatures_mask_user > XCNTXT_MASK to SUPPORTED_XFEATURES_MASK (states supported) How about copy_init_user_fpstate_to_fpregs()? It's shorter and more to the point. --Andy