From: Andy Lutomirski <luto-kltTT9wpgjJwATOyAt5JVQ@public.gmane.org>
To: Khalid Aziz <khalid.aziz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Jonathan Corbet <corbet-T1hC0tSOHrs@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
dingel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
bob.picco-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
"Kirill A. Shutemov"
<kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
"Aneesh Kumar K.V"
<aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
Andrea Arcangeli
<aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Gardner <rob.gardner-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>,
Michal Hocko <mhocko-AlSwsSmVLrQ@public.gmane.org>,
chris.hyser-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org,
Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
Vlastimil Babka <vbabka-AlSwsSmVLrQ@public.gmane.org>,
Konstantin Khlebnikov
<koct9i-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Oleg Nesterov <oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Greg Thelen <gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Jan Kara <jack-AlSwsSmVLrQ@public.gmane.org>,
xiexiuqi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org,
Andrew Lutomirski <luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Eric W. Biederman"
<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>,
Benjamin Segall <bsegall-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqygBwfqmJ+zsg@public.gmane.org>
Subject: Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)
Date: Mon, 7 Mar 2016 10:08:24 -0800 [thread overview]
Message-ID: <CALCETrXN43nT4zq2MpO90VrgK3k+DKHjOHWf7iOhS7TSBmdCPQ@mail.gmail.com> (raw)
In-Reply-To: <56DDC2B6.6020009-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On Mon, Mar 7, 2016 at 10:04 AM, Khalid Aziz <khalid.aziz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> wrote:
> On 03/07/2016 09:56 AM, David Miller wrote:
>>
>> From: Khalid Aziz <khalid.aziz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
>> Date: Mon, 7 Mar 2016 08:07:53 -0700
>>
>>> PR_GET_SPARC_ADICAPS
>>
>>
>> Put this into a new ELF auxiliary vector entry via ARCH_DLINFO.
>>
>> So now all that's left is supposedly the TAG stuff, please explain
>> that to me so I can direct you to the correct existing interface to
>> provide that as well.
>>
>> Really, try to avoid prtctl, it's poorly typed and almost worse than
>> ioctl().
>>
>
> The two remaining operations I am looking at are:
>
> 1. Is PSTATE.mcde bit set for the process? PR_SET_SPARC_ADI provides this in
> its return value in the patch I sent.
>
> 2. Is TTE.mcd set for a given virtual address? PR_GET_SPARC_ADI_STATUS
> provides this function in the patch I sent.
>
> Setting and clearing version tags can be done entirely from userspace:
>
> while (addr < end) {
> asm volatile(
> "stxa %1, [%0]ASI_MCD_PRIMARY\n\t"
> :
> : "r" (addr), "r" (version));
> addr += adicap.blksz;
> }
> so I do not have to add any kernel code for tags.
Is the effect of that to change the tag associated with a page to
which the caller has write access?
I sense DoS issues in your future.
WARNING: multiple messages have this Message-ID (diff)
From: Andy Lutomirski <luto@amacapital.net>
To: Khalid Aziz <khalid.aziz@oracle.com>
Cc: David Miller <davem@davemloft.net>,
Jonathan Corbet <corbet@lwn.net>,
Andrew Morton <akpm@linux-foundation.org>,
dingel@linux.vnet.ibm.com, bob.picco@oracle.com,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
sparclinux@vger.kernel.org, Rob Gardner <rob.gardner@oracle.com>,
Michal Hocko <mhocko@suse.cz>,
chris.hyser@oracle.com, Richard Weinberger <richard@nod.at>,
Vlastimil Babka <vbabka@suse.cz>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Oleg Nesterov <oleg@redhat.com>, Greg Thelen <gthelen@google.com>,
Jan Kara <jack@suse.cz>,
xiexiuqi@huawei.com, Vineet.Gupta1@synopsys.com,
Andrew Lutomirski <luto@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Benjamin Segall <bsegall@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Davidlohr Bueso <dave@stgolabs.net>,
Alexey Dobriyan <adobriyan@gmail.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
linux-arch <linux-arch@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>
Subject: Re: [PATCH v2] sparc64: Add support for Application Data Integrity (ADI)
Date: Mon, 7 Mar 2016 10:08:24 -0800 [thread overview]
Message-ID: <CALCETrXN43nT4zq2MpO90VrgK3k+DKHjOHWf7iOhS7TSBmdCPQ@mail.gmail.com> (raw)
Message-ID: <20160307180824.W2audsU-RE2gHaX8K_XcYEi5akVUo-l8ODiouacb4QA@z> (raw)
In-Reply-To: <56DDC2B6.6020009@oracle.com>
On Mon, Mar 7, 2016 at 10:04 AM, Khalid Aziz <khalid.aziz@oracle.com> wrote:
> On 03/07/2016 09:56 AM, David Miller wrote:
>>
>> From: Khalid Aziz <khalid.aziz@oracle.com>
>> Date: Mon, 7 Mar 2016 08:07:53 -0700
>>
>>> PR_GET_SPARC_ADICAPS
>>
>>
>> Put this into a new ELF auxiliary vector entry via ARCH_DLINFO.
>>
>> So now all that's left is supposedly the TAG stuff, please explain
>> that to me so I can direct you to the correct existing interface to
>> provide that as well.
>>
>> Really, try to avoid prtctl, it's poorly typed and almost worse than
>> ioctl().
>>
>
> The two remaining operations I am looking at are:
>
> 1. Is PSTATE.mcde bit set for the process? PR_SET_SPARC_ADI provides this in
> its return value in the patch I sent.
>
> 2. Is TTE.mcd set for a given virtual address? PR_GET_SPARC_ADI_STATUS
> provides this function in the patch I sent.
>
> Setting and clearing version tags can be done entirely from userspace:
>
> while (addr < end) {
> asm volatile(
> "stxa %1, [%0]ASI_MCD_PRIMARY\n\t"
> :
> : "r" (addr), "r" (version));
> addr += adicap.blksz;
> }
> so I do not have to add any kernel code for tags.
Is the effect of that to change the tag associated with a page to
which the caller has write access?
I sense DoS issues in your future.
next prev parent reply other threads:[~2016-03-07 18:08 UTC|newest]
Thread overview: 115+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 20:39 [PATCH v2] sparc64: Add support for Application Data Integrity (ADI) Khalid Aziz
2016-03-02 23:08 ` Julian Calaby
2016-03-02 23:08 ` Julian Calaby
2016-03-03 0:25 ` Khalid Aziz
2016-03-03 0:25 ` Khalid Aziz
2016-03-03 0:48 ` Julian Calaby
2016-03-03 0:48 ` Julian Calaby
2016-03-03 17:28 ` Khalid Aziz
2016-03-03 17:28 ` Khalid Aziz
2016-03-06 4:07 ` David Miller
2016-03-06 4:07 ` David Miller
2016-03-07 15:07 ` Khalid Aziz
2016-03-07 15:07 ` Khalid Aziz
2016-03-07 15:30 ` Rob Gardner
2016-03-07 15:30 ` Rob Gardner
2016-03-07 15:43 ` Andy Lutomirski
2016-03-07 15:43 ` Andy Lutomirski
2016-03-07 16:06 ` Khalid Aziz
2016-03-07 16:06 ` Khalid Aziz
2016-03-07 17:46 ` Dave Hansen
2016-03-07 17:46 ` Dave Hansen
2016-03-07 17:53 ` Andy Lutomirski
2016-03-07 17:53 ` Andy Lutomirski
2016-03-07 18:12 ` Dave Hansen
2016-03-07 18:12 ` Dave Hansen
2016-03-07 18:39 ` Khalid Aziz
2016-03-07 18:39 ` Khalid Aziz
2016-03-07 18:53 ` Andy Lutomirski
2016-03-07 18:53 ` Andy Lutomirski
[not found] ` <CALCETrVNM7ZcN7WnmLRMDqGrcYXn9xYWJfjMVwFLdiQS63-TcA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-07 19:22 ` David Miller
2016-03-07 19:22 ` David Miller
2016-03-07 19:46 ` Khalid Aziz
2016-03-07 19:46 ` Khalid Aziz
2016-03-07 22:40 ` Dave Hansen
2016-03-07 22:40 ` Dave Hansen
2016-03-08 1:31 ` Rob Gardner
2016-03-08 1:31 ` Rob Gardner
2016-03-07 21:06 ` Khalid Aziz
2016-03-07 21:06 ` Khalid Aziz
2016-03-08 19:57 ` David Miller
2016-03-08 20:16 ` Khalid Aziz
2016-03-08 20:16 ` Khalid Aziz
2016-03-08 20:27 ` David Miller
2016-03-08 20:27 ` David Miller
2016-03-08 20:59 ` Khalid Aziz
2016-03-08 20:59 ` Khalid Aziz
2016-03-07 15:45 ` Khalid Aziz
2016-03-07 15:45 ` Khalid Aziz
2016-03-07 16:45 ` David Miller
2016-03-07 17:51 ` Khalid Aziz
2016-03-07 17:51 ` Khalid Aziz
[not found] ` <56DD9949.1000106-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-03-07 16:56 ` David Miller
2016-03-07 16:56 ` David Miller
2016-03-07 18:04 ` Khalid Aziz
2016-03-07 18:04 ` Khalid Aziz
[not found] ` <56DDC2B6.6020009-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-03-07 18:08 ` Andy Lutomirski [this message]
2016-03-07 18:08 ` Andy Lutomirski
2016-03-07 18:22 ` Khalid Aziz
2016-03-07 18:22 ` Khalid Aziz
2016-03-07 18:49 ` Andy Lutomirski
2016-03-07 18:49 ` Andy Lutomirski
2016-03-07 19:19 ` David Miller
2016-03-07 19:44 ` Khalid Aziz
2016-03-07 19:44 ` Khalid Aziz
2016-03-07 19:54 ` Andy Lutomirski
2016-03-07 19:54 ` Andy Lutomirski
2016-03-07 20:41 ` Khalid Aziz
2016-03-07 20:41 ` Khalid Aziz
[not found] ` <56DDE783.8090009-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-03-07 20:58 ` David Miller
2016-03-07 20:58 ` David Miller
2016-03-07 21:02 ` Andy Lutomirski
2016-03-07 21:02 ` Andy Lutomirski
2016-03-07 21:09 ` Khalid Aziz
2016-03-07 21:09 ` Khalid Aziz
2016-03-07 23:34 ` James Morris
2016-03-07 23:34 ` James Morris
2016-03-07 23:48 ` James Morris
2016-03-07 23:48 ` James Morris
2016-03-08 9:33 ` James Morris
2016-03-08 9:33 ` James Morris
2016-03-07 18:09 ` Rob Gardner
2016-03-07 18:09 ` Rob Gardner
2016-03-07 18:24 ` Khalid Aziz
2016-03-07 18:24 ` Khalid Aziz
2016-03-07 19:16 ` David Miller
2016-03-07 21:33 ` Khalid Aziz
2016-03-07 21:33 ` Khalid Aziz
2016-03-07 21:38 ` David Miller
2016-03-07 23:13 ` Rob Gardner
2016-03-07 23:13 ` Rob Gardner
2016-03-08 4:13 ` David Miller
2016-03-07 23:12 ` Rob Gardner
2016-03-07 23:12 ` Rob Gardner
2016-03-07 23:27 ` Khalid Aziz
2016-03-07 23:27 ` Khalid Aziz
2016-03-08 0:21 ` Khalid Aziz
2016-03-08 0:21 ` Khalid Aziz
2016-03-08 4:24 ` David Miller
2016-03-08 4:24 ` David Miller
2016-03-07 23:32 ` Rob Gardner
2016-03-07 23:32 ` Rob Gardner
2016-03-07 19:09 ` David Miller
2016-03-07 19:09 ` David Miller
2016-03-07 21:27 ` Khalid Aziz
2016-03-07 21:27 ` Khalid Aziz
[not found] ` <56DDF22D.9090102-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2016-03-07 21:34 ` David Miller
2016-03-07 21:34 ` David Miller
2016-03-07 22:30 ` Khalid Aziz
2016-03-07 22:30 ` Khalid Aziz
2016-03-07 17:32 ` Dave Hansen
2016-03-07 17:35 ` Dave Hansen
2016-03-07 18:15 ` Khalid Aziz
2016-03-07 18:15 ` Khalid Aziz
2016-03-07 19:06 ` David Miller
2016-03-07 19:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALCETrXN43nT4zq2MpO90VrgK3k+DKHjOHWf7iOhS7TSBmdCPQ@mail.gmail.com \
--to=luto-klttt9wpgjjwatoyat5jvq@public.gmane.org \
--cc=Vineet.Gupta1-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=aneesh.kumar-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=bob.picco-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=bsegall-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=chris.hyser-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=corbet-T1hC0tSOHrs@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dingel-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=geert-Td1EMuHUCqygBwfqmJ+zsg@public.gmane.org \
--cc=gthelen-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=jack-AlSwsSmVLrQ@public.gmane.org \
--cc=khalid.aziz-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=kirill.shutemov-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=koct9i-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mhocko-AlSwsSmVLrQ@public.gmane.org \
--cc=oleg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=richard-/L3Ra7n9ekc@public.gmane.org \
--cc=rob.gardner-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
--cc=sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=vbabka-AlSwsSmVLrQ@public.gmane.org \
--cc=xiexiuqi-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).