From: Ezequiel Garcia <elezegarcia@gmail.com>
To: Paul Mundt <lethal@linux-sh.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/6] sh: fix compiler warning by properly inlining flat_set_persistent()
Date: Mon, 11 Jun 2012 13:29:07 -0300 [thread overview]
Message-ID: <CALF0-+UDQO9sATy1iTELW70Rd6pDMVumsbksu6GJTYOyZSawTA@mail.gmail.com> (raw)
In-Reply-To: <20120611035005.GC10170@linux-sh.org>
On Mon, Jun 11, 2012 at 12:50 AM, Paul Mundt <lethal@linux-sh.org> wrote:
> On Sun, Jun 10, 2012 at 06:33:10PM -0300, Ezequiel Garcia wrote:
>> On Sat, Jun 9, 2012 at 6:14 AM, Paul Mundt <lethal@linux-sh.org> wrote:
>> > On Sat, Jun 09, 2012 at 05:13:26AM -0300, Ezequiel Garcia wrote:
>> >> This patch removes the following warning:
>> >> fs/binfmt_flat.c:752: warning: unused variable ???persistent???
>> >> There is neither change in functionality, nor extra code generated.
>> >>
>> >> Cc: Paul Mundt <lethal@linux-sh.org>
>> >> Cc: <linux-sh@vger.kernel.org>
>> >> Signed-off-by: Ezequiel Garcia <elezegarcia@gmail.com>
>> >
>> > That's what the cast was for, with what gcc version did that stop
>> > working?
>>
>> I just realized that I should send a v2 (not the whole series just this one)
>> correcting the commit message, since there wasn't a warning to fix
>> in first place.
>>
>> I'll do this soon.
>
> If there's no warning then the point of the patch eludes me. There's
> nothing wrong with consistency, but attempting to fix that which isn't
> broken in the name of consistency borders a bit too closely on pointless
> busy work for my liking.
If you feel like that, then it's perfectly fine with me.
As I already told you, I was going to propagate your magical define to
the rest of arches,
but the inline looked a bit more readable.
Sorry for the noise and thanks for your time.
Regards,
Ezequiel.
prev parent reply other threads:[~2012-06-11 16:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-09 8:13 [PATCH 1/6] sh: fix compiler warning by properly inlining flat_set_persistent() Ezequiel Garcia
2012-06-09 8:13 ` Ezequiel Garcia
2012-06-09 8:13 ` [PATCH 2/6] arm: " Ezequiel Garcia
2012-06-09 8:13 ` Ezequiel Garcia
2012-07-03 18:53 ` Ezequiel Garcia
2012-06-09 8:13 ` [PATCH 3/6] xtensa: " Ezequiel Garcia
2012-06-09 8:13 ` Ezequiel Garcia
2012-06-09 8:13 ` [PATCH 4/6] microblaze: " Ezequiel Garcia
2012-06-09 8:13 ` Ezequiel Garcia
2012-06-09 8:13 ` [PATCH 5/6] m32r: " Ezequiel Garcia
2012-06-09 8:13 ` Ezequiel Garcia
2012-06-09 8:13 ` [PATCH 6/6] h8300: " Ezequiel Garcia
2012-06-09 8:13 ` Ezequiel Garcia
2012-06-09 9:14 ` [PATCH 1/6] sh: " Paul Mundt
2012-06-09 12:01 ` Ezequiel Garcia
2012-06-09 12:01 ` Ezequiel Garcia
2012-06-10 21:33 ` Ezequiel Garcia
2012-06-10 21:33 ` Ezequiel Garcia
2012-06-11 3:50 ` Paul Mundt
2012-06-11 3:50 ` Paul Mundt
2012-06-11 16:29 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALF0-+UDQO9sATy1iTELW70Rd6pDMVumsbksu6GJTYOyZSawTA@mail.gmail.com \
--to=elezegarcia@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).