From: Rob Herring <robh@kernel.org>
To: Guo Ren <ren_guo@c-sky.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
"open list:GENERIC INCLUDE/ASM HEADER FILES"
<linux-arch@vger.kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] csky: remove Devicetree dtb Kbuild rules
Date: Tue, 30 Oct 2018 07:30:43 -0500 [thread overview]
Message-ID: <CAL_JsqLu6Ug_32SGgELP5SCJnmcz7mD96xGD-d=3=edAOpSEGg@mail.gmail.com> (raw)
In-Reply-To: <1540889473-13871-1-git-send-email-ren_guo@c-sky.com>
On Tue, Oct 30, 2018 at 3:51 AM Guo Ren <ren_guo@c-sky.com> wrote:
>
> This modification is based on commit 37c8a5fafa3b to remove the dtb
> Kbuild rules in arch/csky and use common dtb build rules. Also remove
> the builtin-dtb implementation in arch/csky.
>
> Signed-off-by: Guo Ren <ren_guo@c-sky.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/csky/Kconfig.debug | 10 +---------
> arch/csky/Makefile | 13 +------------
> arch/csky/boot/dts/Makefile | 7 -------
> 3 files changed, 2 insertions(+), 28 deletions(-)
>
> diff --git a/arch/csky/Kconfig.debug b/arch/csky/Kconfig.debug
> index 48cf6ff..22a162cd 100644
> --- a/arch/csky/Kconfig.debug
> +++ b/arch/csky/Kconfig.debug
> @@ -1,9 +1 @@
> -menu "C-SKY Debug Options"
> -config CSKY_BUILTIN_DTB
> - string "Use kernel builtin dtb"
> - help
> - User could define the dtb instead of the one which is passed from
> - bootloader.
> - Sometimes for debug, we want to use a built-in dtb and then we needn't
> - modify bootloader at all.
> -endmenu
> +# dummy file, do not delete
> diff --git a/arch/csky/Makefile b/arch/csky/Makefile
> index 67a4ae1..c639fc1 100644
> --- a/arch/csky/Makefile
> +++ b/arch/csky/Makefile
> @@ -65,26 +65,15 @@ libs-y += arch/csky/lib/ \
> $(shell $(CC) $(KBUILD_CFLAGS) $(KCFLAGS) -print-libgcc-file-name)
>
> boot := arch/csky/boot
> -ifneq '$(CONFIG_CSKY_BUILTIN_DTB)' '""'
> core-y += $(boot)/dts/
> -endif
>
> all: zImage
>
> -
> -dtbs: scripts
> - $(Q)$(MAKE) $(build)=$(boot)/dts
> -
> -%.dtb %.dtb.S %.dtb.o: scripts
> - $(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@
> -
> -zImage Image uImage: vmlinux dtbs
> +zImage Image uImage: vmlinux
> $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
>
> archclean:
> $(Q)$(MAKE) $(clean)=$(boot)
> - $(Q)$(MAKE) $(clean)=$(boot)/dts
> - rm -rf arch/csky/include/generated
>
> define archhelp
> echo '* zImage - Compressed kernel image (arch/$(ARCH)/boot/zImage)'
> diff --git a/arch/csky/boot/dts/Makefile b/arch/csky/boot/dts/Makefile
> index 305e81a..19a7f02 100644
> --- a/arch/csky/boot/dts/Makefile
> +++ b/arch/csky/boot/dts/Makefile
> @@ -1,13 +1,6 @@
> dtstree := $(srctree)/$(src)
>
> -ifneq '$(CONFIG_CSKY_BUILTIN_DTB)' '""'
> -builtindtb-y := $(patsubst "%",%,$(CONFIG_CSKY_BUILTIN_DTB))
> -dtb-y += $(builtindtb-y).dtb
> -obj-y += $(builtindtb-y).dtb.o
> -.SECONDARY: $(obj)/$(builtindtb-y).dtb.S
> -else
> dtb-y := $(patsubst $(dtstree)/%.dts,%.dtb, $(wildcard $(dtstree)/*.dts))
> -endif
>
> always += $(dtb-y)
> clean-files += *.dtb *.dtb.S
These 2 lines can also be removed.
next prev parent reply other threads:[~2018-10-30 21:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 8:51 [PATCH] csky: remove Devicetree dtb Kbuild rules Guo Ren
2018-10-30 12:30 ` Rob Herring [this message]
2018-10-30 17:57 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqLu6Ug_32SGgELP5SCJnmcz7mD96xGD-d=3=edAOpSEGg@mail.gmail.com' \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=ren_guo@c-sky.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).