From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 11/18] pinctrl: Add pinctrl driver for STM32 MCUs Date: Fri, 6 Mar 2015 10:57:08 +0100 Message-ID: References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <1424455277-29983-12-git-send-email-mcoquelin.stm32@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Linus Walleij Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo List-Id: linux-arch.vger.kernel.org 2015-03-06 10:24 GMT+01:00 Linus Walleij : > On Fri, Feb 20, 2015 at 7:01 PM, Maxime Coquelin > wrote: > >> This driver adds pinctrl and GPIO support to STMicrolectronic's >> STM32 family of MCUs. >> >> Pin muxing and GPIO handling have been tested on STM32F429 >> based Discovery board. >> >> Signed-off-by: Maxime Coquelin > > (...) >> +config PINCTRL_STM32 >> + bool "STMicroelectronics STM32 pinctrl driver" >> + depends on OF >> + depends on ARCH_STM32 || COMPILE_TEST >> + select PINMUX >> + select PINCONF >> + select GPIOLIB_IRQCHIP >> + help >> + This selects the device tree based generic pinctrl driver for STM32. > > Good start! Especially that you use GPIOLIB_IRQCHIP. > > But this (as discussed earlier) should select GENERIC_PINCONF > > Stopping review here so you can reengineer it a bit using GENERIC_PINCONF > for next submission. > > Also think about pinmux in single registers, whether you want to do this > with a single value for a register or using strings to identify groups > and functions. Thanks for the review. I will digest all this, and come back with another solution :) Best regards, Maxime > > Yours, > Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f51.google.com ([74.125.82.51]:37687 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752896AbbCFJ5K (ORCPT ); Fri, 6 Mar 2015 04:57:10 -0500 MIME-Version: 1.0 In-Reply-To: References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <1424455277-29983-12-git-send-email-mcoquelin.stm32@gmail.com> Date: Fri, 6 Mar 2015 10:57:08 +0100 Message-ID: Subject: Re: [PATCH v2 11/18] pinctrl: Add pinctrl driver for STM32 MCUs From: Maxime Coquelin Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Walleij Cc: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-api@vger.kernel.org" Message-ID: <20150306095708.NJpN2SAQS4JexOqDVajpOsQfzeld5NVziZTVc8zLq8w@z> 2015-03-06 10:24 GMT+01:00 Linus Walleij : > On Fri, Feb 20, 2015 at 7:01 PM, Maxime Coquelin > wrote: > >> This driver adds pinctrl and GPIO support to STMicrolectronic's >> STM32 family of MCUs. >> >> Pin muxing and GPIO handling have been tested on STM32F429 >> based Discovery board. >> >> Signed-off-by: Maxime Coquelin > > (...) >> +config PINCTRL_STM32 >> + bool "STMicroelectronics STM32 pinctrl driver" >> + depends on OF >> + depends on ARCH_STM32 || COMPILE_TEST >> + select PINMUX >> + select PINCONF >> + select GPIOLIB_IRQCHIP >> + help >> + This selects the device tree based generic pinctrl driver for STM32. > > Good start! Especially that you use GPIOLIB_IRQCHIP. > > But this (as discussed earlier) should select GENERIC_PINCONF > > Stopping review here so you can reengineer it a bit using GENERIC_PINCONF > for next submission. > > Also think about pinmux in single registers, whether you want to do this > with a single value for a register or using strings to identify groups > and functions. Thanks for the review. I will digest all this, and come back with another solution :) Best regards, Maxime > > Yours, > Linus Walleij