From mboxrd@z Thu Jan 1 00:00:00 1970 From: Firoz Khan Subject: Re: [PATCH 2/4] m68k: Replace NR_syscalls macro from asm/unistd.h Date: Tue, 18 Sep 2018 12:46:54 +0530 Message-ID: References: <1533791723-3882-1-git-send-email-firoz.khan@linaro.org> <1533791723-3882-3-git-send-email-firoz.khan@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven Cc: linux-m68k , y2038 Mailman List , Linux Kernel Mailing List , Linux-Arch , Arnd Bergmann , Deepa Dinamani , Marcin Juszkiewicz List-Id: linux-arch.vger.kernel.org On 9 August 2018 at 13:00, Geert Uytterhoeven wrote: > Hi Firoz, > > One first comment below... > > On Thu, Aug 9, 2018 at 7:16 AM Firoz Khan wrote: >> NR_syscalls macro holds the number of system call exist in m68k >> architecture. This macro is currently the part of asm/unistd.h file. >> We have to change the value of NR_syscalls, if we add or delete a >> system call. >> >> One of patch in this patch series has a script which will generate >> a uapi header based on syscall.tbl file. The syscall.tbl file >> contains the number of system call information. So we have two >> option to update NR_syscalls value. >> >> 1. Update NR_syscalls in asm/unistd.h manually by counting the >> no.of system calls. No need to update NR_syscalls untill >> we either add a new system call or delete an existing system >> call. >> >> 2. We can keep this feature it above mentioned script, that'll >> count the number of syscalls and keep it in a generated file. >> In this case we don't need to explicitly update NR_syscalls >> in asm/unistd.h file. >> >> The 2nd option will be the recommended one. For that, I moved the >> NR_syscalls macro from asm/unistd.h to uapi/asm/unistd.h. The macro >> name also changed form NR_syscalls to __NR_syscalls for making the >> name convention same across all architecture. While __NR_syscalls >> isn't strictly part of the uapi, having it as part of the generated >> header to simplifies the implementation. > > It can indeed not be part of the UAPI, as UAPI definitions can never change, > while new syscalls will be added in the future, increasing the number ;-) Thanks for your reply :) Sorry for the delayed response :( I would like to keep __NR_syscalls macro to uapi header in order to simplify the system call table generation script. Otherwise the __NR_syscalls macro need to update manually. That become a problem. Please check the below implementation in uapi file make sense? It is an easy workaround to leave __NR_syscalls macro in uapi/asm/unistd.h and enclose it in #ifdef __KERNEL__ ... ... #define __NR_pwritev2 378 #define __NR_statx 379 #ifdef __KERNEL__ #define __NR_syscalls 380 #endif ... ... > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-f194.google.com ([209.85.219.194]:43001 "EHLO mail-yb1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727140AbeIRMsL (ORCPT ); Tue, 18 Sep 2018 08:48:11 -0400 Received: by mail-yb1-f194.google.com with SMTP id 13-v6so386412ybn.9 for ; Tue, 18 Sep 2018 00:16:55 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1533791723-3882-1-git-send-email-firoz.khan@linaro.org> <1533791723-3882-3-git-send-email-firoz.khan@linaro.org> From: Firoz Khan Date: Tue, 18 Sep 2018 12:46:54 +0530 Message-ID: Subject: Re: [PATCH 2/4] m68k: Replace NR_syscalls macro from asm/unistd.h Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: linux-m68k , y2038 Mailman List , Linux Kernel Mailing List , Linux-Arch , Arnd Bergmann , Deepa Dinamani , Marcin Juszkiewicz Message-ID: <20180918071654.2ZMdpMZ_tCAyjJvclJXP_MTUPKmJxT466swbW0AGRyg@z> On 9 August 2018 at 13:00, Geert Uytterhoeven wrote: > Hi Firoz, > > One first comment below... > > On Thu, Aug 9, 2018 at 7:16 AM Firoz Khan wrote: >> NR_syscalls macro holds the number of system call exist in m68k >> architecture. This macro is currently the part of asm/unistd.h file. >> We have to change the value of NR_syscalls, if we add or delete a >> system call. >> >> One of patch in this patch series has a script which will generate >> a uapi header based on syscall.tbl file. The syscall.tbl file >> contains the number of system call information. So we have two >> option to update NR_syscalls value. >> >> 1. Update NR_syscalls in asm/unistd.h manually by counting the >> no.of system calls. No need to update NR_syscalls untill >> we either add a new system call or delete an existing system >> call. >> >> 2. We can keep this feature it above mentioned script, that'll >> count the number of syscalls and keep it in a generated file. >> In this case we don't need to explicitly update NR_syscalls >> in asm/unistd.h file. >> >> The 2nd option will be the recommended one. For that, I moved the >> NR_syscalls macro from asm/unistd.h to uapi/asm/unistd.h. The macro >> name also changed form NR_syscalls to __NR_syscalls for making the >> name convention same across all architecture. While __NR_syscalls >> isn't strictly part of the uapi, having it as part of the generated >> header to simplifies the implementation. > > It can indeed not be part of the UAPI, as UAPI definitions can never change, > while new syscalls will be added in the future, increasing the number ;-) Thanks for your reply :) Sorry for the delayed response :( I would like to keep __NR_syscalls macro to uapi header in order to simplify the system call table generation script. Otherwise the __NR_syscalls macro need to update manually. That become a problem. Please check the below implementation in uapi file make sense? It is an easy workaround to leave __NR_syscalls macro in uapi/asm/unistd.h and enclose it in #ifdef __KERNEL__ ... ... #define __NR_pwritev2 378 #define __NR_statx 379 #ifdef __KERNEL__ #define __NR_syscalls 380 #endif ... ... > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds