From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D167C7EE2A for ; Tue, 23 May 2023 08:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236164AbjEWIS4 (ORCPT ); Tue, 23 May 2023 04:18:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236111AbjEWISL (ORCPT ); Tue, 23 May 2023 04:18:11 -0400 Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 244C7E5B for ; Tue, 23 May 2023 01:16:07 -0700 (PDT) Received: by mail-vk1-xa2b.google.com with SMTP id 71dfb90a1353d-456d241fcdcso1904659e0c.0 for ; Tue, 23 May 2023 01:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1684829766; x=1687421766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ekkX5ovoO1DzJHorTtfGF/BFqQaZlWm6jALsPFR/4AA=; b=e9R6QFUt8iG4VMgXDNLKpBFcZWuvpjp8djRXoItHJYGP9mbhrfLBweV3gxtM8JcVC/ 2I1MbkIiIY2DoxsigjupTNGZJ6jq1gC5LWd7XJthhipFE9b1NTLi0nXkO4oyMPJWslUd R+43UM2TydbecRvpGyeDxsJRtURNcjwwdXxTl0AYHNf2zAbM202PEF/TZy1xoyWzpiJK Bm7ELQzbbzEcWAJ6JvW+GaJ9x2gdplkbuxndVNpNypYlMODVZIyBOtzxs7hmm22HwLCZ TEaPmcNLWcHYTJAoM7lShNgU2yZ1vDL36m+22YE58HanHBziQIrs3ce0JiYm9fdNuopb HkSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684829766; x=1687421766; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ekkX5ovoO1DzJHorTtfGF/BFqQaZlWm6jALsPFR/4AA=; b=Ww3uxCRL998Fw9hMdRg62j4MkyjksMsOpmFumhfpjAD5S3okzv2ktbEmxcmD24Tpea yGIXR/FgDyB1yOnKUaxqpxO8+mJ7E9yXD+PaRZwd/9p/xgHWrC43pgw0yekbzs9WG7kc 3LEf4nuNX7nDrkVk3YwnsOFPuf0fd177jMyy122JssI4LAO20Z2yPPDcEMPjeRHg0uGo xW8AI/w5mQTMJjfdqDjFGmPCA1hwRys17LuxjqBUTxR7PgU5BoIOnzdkmEuYDVt2H2kW aej9DkCQL9BI07vP4Pzyifl9yB/QJg1awIJcasn0G9inkgm+vOqbPvCwwaF9ICZ1wnwv DzvQ== X-Gm-Message-State: AC+VfDz6xx+5Omk0N9RnMAXFMOXCejmPkrpzhIcqD5uGb/jXfxPaQkq5 IOUsvqJiGyyk29L0RUpI7KUGZGhitsk8blN+TSrc9A== X-Google-Smtp-Source: ACHHUZ6tnPKQXddjF+yPByGlNbu2YK50eEvYLu3XkRm64FzUYKCXda3es1LXLHr8GrVyAxXwsfYYq1upmKF1RmkKZOY= X-Received: by 2002:a1f:6046:0:b0:456:ffb8:8901 with SMTP id u67-20020a1f6046000000b00456ffb88901mr4334382vkb.15.1684829766186; Tue, 23 May 2023 01:16:06 -0700 (PDT) MIME-Version: 1.0 References: <20230522105049.1467313-1-schnelle@linux.ibm.com> <20230522105049.1467313-12-schnelle@linux.ibm.com> In-Reply-To: <20230522105049.1467313-12-schnelle@linux.ibm.com> From: Bartosz Golaszewski Date: Tue, 23 May 2023 10:15:55 +0200 Message-ID: Subject: Re: [PATCH v5 11/44] gpio: add HAS_IOPORT dependencies To: Niklas Schnelle Cc: Arnd Bergmann , Linus Walleij , Greg Kroah-Hartman , Bjorn Helgaas , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Mauro Carvalho Chehab , Alan Stern , "Rafael J. Wysocki" , Geert Uytterhoeven , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-pci@vger.kernel.org, Arnd Bergmann , linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, May 22, 2023 at 12:51=E2=80=AFPM Niklas Schnelle wrote: > > In a future patch HAS_IOPORT=3Dn will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Reviewed-by: Linus Walleij > Co-developed-by: Arnd Bergmann > Signed-off-by: Arnd Bergmann > Signed-off-by: Niklas Schnelle > --- > drivers/gpio/Kconfig | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig > index 5521f060d58e..a470ec8d617b 100644 > --- a/drivers/gpio/Kconfig > +++ b/drivers/gpio/Kconfig > @@ -704,18 +704,6 @@ config GPIO_VISCONTI > help > Say yes here to support GPIO on Tohisba Visconti. > > -config GPIO_VX855 > - tristate "VIA VX855/VX875 GPIO" > - depends on (X86 || COMPILE_TEST) && PCI > - select MFD_CORE > - select MFD_VX855 > - help > - Support access to the VX855/VX875 GPIO lines through the GPIO l= ibrary. > - > - This driver provides common support for accessing the device. > - Additional drivers must be enabled in order to use the > - functionality of the device. > - > config GPIO_WCD934X > tristate "Qualcomm Technologies Inc WCD9340/WCD9341 GPIO controll= er driver" > depends on MFD_WCD934X && OF_GPIO > @@ -835,7 +823,19 @@ config GPIO_IDT3243X > endmenu > > menu "Port-mapped I/O GPIO drivers" > - depends on X86 # Unconditional I/O space access > + depends on X86 && HAS_IOPORT # I/O space access > + > +config GPIO_VX855 > + tristate "VIA VX855/VX875 GPIO" > + depends on PCI > + select MFD_CORE > + select MFD_VX855 > + help > + Support access to the VX855/VX875 GPIO lines through the GPIO l= ibrary. > + > + This driver provides common support for accessing the device. > + Additional drivers must be enabled in order to use the > + functionality of the device. > > config GPIO_I8255 > tristate > -- > 2.39.2 > I already applied v4. Has this changed since the last version? If not, then you can drop it now from your series. Bart