From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Dorminy Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Received: from us-smtp-1.mimecast.com ([207.211.31.81]:21372 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728008AbgEACiZ (ORCPT ); Thu, 30 Apr 2020 22:38:25 -0400 Received: by mail-ua1-f72.google.com with SMTP id v17so3666675uao.7 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Wei Liu Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com ([207.211.31.81]:21372 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728008AbgEACiZ (ORCPT ); Thu, 30 Apr 2020 22:38:25 -0400 Received: by mail-ua1-f72.google.com with SMTP id v17so3666675uao.7 for ; Thu, 30 Apr 2020 19:38:22 -0700 (PDT) MIME-Version: 1.0 References: <20200414131348.444715-1-hch@lst.de> <20200414131348.444715-22-hch@lst.de> <20200414151344.zgt2pnq7cjq2bgv6@debian> In-Reply-To: From: John Dorminy Date: Thu, 30 Apr 2020 22:38:10 -0400 Message-ID: Subject: Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Wei Liu Cc: Christoph Hellwig , Andrew Morton , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , x86@kernel.org, David Airlie , Daniel Vetter , Laura Abbott , Sumit Semwal , Sakari Ailus , Minchan Kim , Nitin Gupta , Robin Murphy , Christophe Leroy , Peter Zijlstra , linuxppc-dev@lists.ozlabs.org, linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, bpf@vger.kernel.org, Linux Kernel Mailing List , Michael Kelley , Gao Xiang Message-ID: <20200501023810.cyGC3rDVVVrzZt7Dzz7lmM1RNcCwkfBnjYoLt_U_4x0@z> >> On Tue, Apr 14, 2020 at 03:13:40PM +0200, Christoph Hellwig wrote: >> > The pgprot argument to __vmalloc is always PROT_KERNEL now, so remove >> > it. Greetings; I recently noticed this change via the linux-next tree. It may not be possible to edit at this late date, but the change description refers to PROT_KERNEL, which is a symbol which does not appear to exist; perhaps PAGE_KERNEL was meant? The mismatch caused me and a couple other folks some confusion briefly until we decided it was supposed to be PAGE_KERNEL; if it's not too late, editing the description to clarify so would be nice. Many thanks. John Dorminy