Re: [PATCH v2] xtensa: define NO_IRQ as 0, remove other definitions

[Max Filippov <jcmvbkbc@gmail.com>]

On Thu, Sep 12, 2013 at 11:26 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Sep 12, 2013 at 9:17 AM, Max Filippov <jcmvbkbc@gmail.com> wrote:
>>
>> sound/soc/fsl/fsl_ssi.c: In function 'fsl_ssi_probe':
>> sound/soc/fsl/fsl_ssi.c:939:26: error: 'NO_IRQ' undeclared (first use in this function)
>>
>> Previous definitions (-1) were correct when used as a hardware IRQ number,
>> but are incorrect as a mapped IRQ number.
>>
>> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
>> ---
>>  arch/xtensa/include/asm/irq.h                      |    4 ++++
>>  .../platforms/xtfpga/include/platform/hardware.h   |    4 ----
>>  arch/xtensa/variants/s6000/include/variant/irq.h   |    1 -
>>  3 files changed, 4 insertions(+), 5 deletions(-)
>
> Shouldn't sound/soc/fsl/fsl_ssi.c be changed instead:
>
> -if (ssi_private->irq == NO_IRQ) {
> +if (!ssi_private->irq) {

I agree, this needs to be fixed too.

> Cfr. the thread https://lkml.org/lkml/2013/7/25/642

I saw that thread and I don't see that patch applied anywhere.

Thanks.
-- Max