From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH v3 3/7] arch/sparc: Define config parameter CPU_BIG_ENDIAN Date: Wed, 24 May 2017 11:48:44 +0200 Message-ID: References: <1495575958-1022566-1-git-send-email-babu.moger@oracle.com> <1495575958-1022566-4-git-send-email-babu.moger@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-it0-f66.google.com ([209.85.214.66]:33743 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbdEXJsr (ORCPT ); Wed, 24 May 2017 05:48:47 -0400 In-Reply-To: <1495575958-1022566-4-git-send-email-babu.moger@oracle.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Babu Moger Cc: "David S. Miller" , Peter Zijlstra , Ingo Molnar , Arnd Bergmann , shannon.nelson@oracle.com, haakon.bugge@oracle.com, steven.sistare@oracle.com, vijay.ac.kumar@oracle.com, jane.chu@oracle.com, sparclinux , "linux-kernel@vger.kernel.org" , Linux-Arch On Tue, May 23, 2017 at 11:45 PM, Babu Moger wrote: > Found this problem while enabling queued rwlock on SPARC. > The parameter CONFIG_CPU_BIG_ENDIAN is used to clear the > specific byte in qrwlock structure. Without this parameter, > we clear the wrong byte. Here is the code. > > static inline u8 *__qrwlock_write_byte(struct qrwlock *lock) > { > return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN); > } > > Define CPU_BIG_ENDIAN for SPARC to fix it. > > Signed-off-by: Babu Moger > Reviewed-by: H=C3=A5kon Bugge > Reviewed-by: Jane Chu > Reviewed-by: Shannon Nelson > Reviewed-by: Vijay Kumar > --- > arch/sparc/Kconfig | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig > index 908f019..2f58c16 100644 > --- a/arch/sparc/Kconfig > +++ b/arch/sparc/Kconfig > @@ -92,6 +92,10 @@ config ARCH_DEFCONFIG > config ARCH_PROC_KCORE_TEXT > def_bool y > > +config CPU_BIG_ENDIAN > + bool > + default y if SPARC def_bool y? Gr{oetje,eeting}s, Geert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f66.google.com ([209.85.214.66]:33743 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbdEXJsr (ORCPT ); Wed, 24 May 2017 05:48:47 -0400 MIME-Version: 1.0 In-Reply-To: <1495575958-1022566-4-git-send-email-babu.moger@oracle.com> References: <1495575958-1022566-1-git-send-email-babu.moger@oracle.com> <1495575958-1022566-4-git-send-email-babu.moger@oracle.com> From: Geert Uytterhoeven Date: Wed, 24 May 2017 11:48:44 +0200 Message-ID: Subject: Re: [PATCH v3 3/7] arch/sparc: Define config parameter CPU_BIG_ENDIAN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-arch-owner@vger.kernel.org List-ID: To: Babu Moger Cc: "David S. Miller" , Peter Zijlstra , Ingo Molnar , Arnd Bergmann , shannon.nelson@oracle.com, haakon.bugge@oracle.com, steven.sistare@oracle.com, vijay.ac.kumar@oracle.com, jane.chu@oracle.com, sparclinux , "linux-kernel@vger.kernel.org" , Linux-Arch Message-ID: <20170524094844.HgC5ghfzri4gFhEWuoK-XxPs4-niaGUX62MY4c62xZA@z> On Tue, May 23, 2017 at 11:45 PM, Babu Moger wrote: > Found this problem while enabling queued rwlock on SPARC. > The parameter CONFIG_CPU_BIG_ENDIAN is used to clear the > specific byte in qrwlock structure. Without this parameter, > we clear the wrong byte. Here is the code. > > static inline u8 *__qrwlock_write_byte(struct qrwlock *lock) > { > return (u8 *)lock + 3 * IS_BUILTIN(CONFIG_CPU_BIG_ENDIAN); > } > > Define CPU_BIG_ENDIAN for SPARC to fix it. > > Signed-off-by: Babu Moger > Reviewed-by: H=C3=A5kon Bugge > Reviewed-by: Jane Chu > Reviewed-by: Shannon Nelson > Reviewed-by: Vijay Kumar > --- > arch/sparc/Kconfig | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/sparc/Kconfig b/arch/sparc/Kconfig > index 908f019..2f58c16 100644 > --- a/arch/sparc/Kconfig > +++ b/arch/sparc/Kconfig > @@ -92,6 +92,10 @@ config ARCH_DEFCONFIG > config ARCH_PROC_KCORE_TEXT > def_bool y > > +config CPU_BIG_ENDIAN > + bool > + default y if SPARC def_bool y? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k= .org In personal conversations with technical people, I call myself a hacker. Bu= t when I'm talking to journalists I just say "programmer" or something like t= hat. -- Linus Torvalds