From mboxrd@z Thu Jan  1 00:00:00 1970
From: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 07/20] arch,cris: Fold atomic_ops
Date: Thu, 8 May 2014 17:12:31 +0200
Message-ID: <CAMuHMdV7FUC+p5XqwLZmqJRLYv1qhu5hf0M_e5pASBRHgFAhCA@mail.gmail.com>
References: <20140508135840.956784204@infradead.org>
	<20140508135852.104572724@infradead.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Return-path: <linux-arch-owner@vger.kernel.org>
Received: from mail-ig0-f179.google.com ([209.85.213.179]:38355 "EHLO
	mail-ig0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751856AbaEHPMc (ORCPT
	<rfc822;linux-arch@vger.kernel.org>); Thu, 8 May 2014 11:12:32 -0400
In-Reply-To: <20140508135852.104572724@infradead.org>
Sender: linux-arch-owner@vger.kernel.org
List-ID: <linux-arch.vger.kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Linux-Arch <linux-arch@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linus Torvalds <torvalds@linux-foundation.org>, Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@kernel.org>, Will Deacon <will.deacon@arm.com>, Paul McKenney <paulmck@linux.vnet.ibm.com>, Jesper Nilsson <jesper.nilsson@axis.com>, Mikael Starvik <starvik@axis.com>

Hi Peter,

On Thu, May 8, 2014 at 3:58 PM, Peter Zijlstra <peterz@infradead.org> wrote:
> Many of the atomic op implementations are the same except for one
> instruction; fold the lot into a few CPP macros and reduce LoC.
>
> This also prepares for easy addition of new ops.
>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Jesper Nilsson <jesper.nilsson@axis.com>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Mikael Starvik <starvik@axis.com>
> Signed-off-by: Peter Zijlstra <peterz@infradead.org>
> ---
>  arch/cris/include/arch-v10/arch/system.h |    2 -
>  arch/cris/include/asm/atomic.h           |   57 +++++++++++++------------------
>  2 files changed, 25 insertions(+), 34 deletions(-)
>
> Index: linux-2.6/arch/cris/include/arch-v10/arch/system.h
> ===================================================================
> --- linux-2.6.orig/arch/cris/include/arch-v10/arch/system.h
> +++ linux-2.6/arch/cris/include/arch-v10/arch/system.h
> @@ -36,8 +36,6 @@ static inline unsigned long _get_base(ch
>    return 0;
>  }
>
> -#define nop() __asm__ __volatile__ ("nop");
> -

Is this change supposed to be part of this series?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds