From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 13/27] m68k: Use common bits from generic tlb.h Date: Wed, 14 May 2014 21:34:34 +0200 Message-ID: References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-14-git-send-email-richard@nod.at> <5373C36E.3020900@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <5373C36E.3020900@nod.at> Sender: linux-m68k-owner@vger.kernel.org To: Richard Weinberger Cc: Linux-Arch , Arnd Bergmann , "linux-kernel@vger.kernel.org" , linux-m68k List-Id: linux-arch.vger.kernel.org Hi Richard, On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger wrote: >> But why this sudden #ifdef checks? > > They are needed because in pgalloc.h you have: > #ifdef CONFIG_MMU > #include > #if defined(CONFIG_COLDFIRE) > #include > #elif defined(CONFIG_SUN3) > #include > #else > #include > #endif > > And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions. > Therefore we need to define them such that the generic tlb.h versions will not clash > with yours. Thanks for the clarification! Perhaps this deserves a comment: /* Applies to Classic m68k MMU only */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ie0-f173.google.com ([209.85.223.173]:36372 "EHLO mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751068AbaENTef (ORCPT ); Wed, 14 May 2014 15:34:35 -0400 MIME-Version: 1.0 In-Reply-To: <5373C36E.3020900@nod.at> References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-14-git-send-email-richard@nod.at> <5373C36E.3020900@nod.at> Date: Wed, 14 May 2014 21:34:34 +0200 Message-ID: Subject: Re: [PATCH 13/27] m68k: Use common bits from generic tlb.h From: Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Richard Weinberger Cc: Linux-Arch , Arnd Bergmann , "linux-kernel@vger.kernel.org" , linux-m68k Message-ID: <20140514193434.xecbR-6W9ThGoMJ41fKMSFllNTz33vjOtHzvxIU62SA@z> Hi Richard, On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger wrote: >> But why this sudden #ifdef checks? > > They are needed because in pgalloc.h you have: > #ifdef CONFIG_MMU > #include > #if defined(CONFIG_COLDFIRE) > #include > #elif defined(CONFIG_SUN3) > #include > #else > #include > #endif > > And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions. > Therefore we need to define them such that the generic tlb.h versions will not clash > with yours. Thanks for the clarification! Perhaps this deserves a comment: /* Applies to Classic m68k MMU only */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds