From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Greg Ungerer <gerg@uclinux.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"chris@zankel.net" <chris@zankel.net>,
"cmetcalf@tilera.com" <cmetcalf@tilera.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"deller@gmx.de" <deller@gmx.de>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
"jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"monstr@monstr.eu" <monstr@monstr.eu>,
"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"sam@ravnborg.org" <sam@ravnborg.org>, schwidefsky@de.
Subject: Re: [PATCH v3 09/17] m68k: io: implement dummy relaxed accessor macros for writes
Date: Thu, 25 Sep 2014 11:51:10 +0200 [thread overview]
Message-ID: <CAMuHMdVpCs2RtsdDpdN3tp9_Xa1TzDMM3Z5+pP07B7Y3He2hLA@mail.gmail.com> (raw)
In-Reply-To: <20140925093309.GG20043@arm.com>
On Thu, Sep 25, 2014 at 11:33 AM, Will Deacon <will.deacon@arm.com> wrote:
>> Putting them here means they won't have any multiple include protection
>> (there is no "#ifndef _IO_H" around them). Doesn't seem to lead to
>> any problems in practice. Just flagging it...
>
> That's easy enough to fix, and actually, we should have __KERNEL__ checks
> here too. Fixup below.
Why do we need __KERNEL__ checks? <asm/io.h> is not exported.
BTW, it seems there are many __KERNEL__ checks in arch/*/include/asm/
we don't need.
Or do I need more coffee?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
WARNING: multiple messages have this Message-ID (diff)
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Greg Ungerer <gerg@uclinux.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
"chris@zankel.net" <chris@zankel.net>,
"cmetcalf@tilera.com" <cmetcalf@tilera.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"deller@gmx.de" <deller@gmx.de>,
"dhowells@redhat.com" <dhowells@redhat.com>,
"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"jcmvbkbc@gmail.com" <jcmvbkbc@gmail.com>,
"jesper.nilsson@axis.com" <jesper.nilsson@axis.com>,
"mingo@redhat.com" <mingo@redhat.com>,
"monstr@monstr.eu" <monstr@monstr.eu>,
"paulmck@linux.vnet.ibm.com" <paulmck@linux.vnet.ibm.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"sam@ravnborg.org" <sam@ravnborg.org>,
"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
"starvik@axis.com" <starvik@axis.com>,
"takata@linux-m32r.org" <takata@linux-m32r.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"daniel.thompson@linaro.org" <daniel.thompson@linaro.org>,
"broonie@linaro.org" <broonie@linaro.org>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>
Subject: Re: [PATCH v3 09/17] m68k: io: implement dummy relaxed accessor macros for writes
Date: Thu, 25 Sep 2014 11:51:10 +0200 [thread overview]
Message-ID: <CAMuHMdVpCs2RtsdDpdN3tp9_Xa1TzDMM3Z5+pP07B7Y3He2hLA@mail.gmail.com> (raw)
Message-ID: <20140925095110.AI4Iag__1ltgnbYGn7PhqM_7aceIV4zBSEb255486_8@z> (raw)
In-Reply-To: <20140925093309.GG20043@arm.com>
On Thu, Sep 25, 2014 at 11:33 AM, Will Deacon <will.deacon@arm.com> wrote:
>> Putting them here means they won't have any multiple include protection
>> (there is no "#ifndef _IO_H" around them). Doesn't seem to lead to
>> any problems in practice. Just flagging it...
>
> That's easy enough to fix, and actually, we should have __KERNEL__ checks
> here too. Fixup below.
Why do we need __KERNEL__ checks? <asm/io.h> is not exported.
BTW, it seems there are many __KERNEL__ checks in arch/*/include/asm/
we don't need.
Or do I need more coffee?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2014-09-25 9:51 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 17:17 [PATCH v3 00/17] Cross-architecture definitions of relaxed MMIO accessors Will Deacon
2014-09-24 17:17 ` [PATCH v3 01/17] asm-generic: io: implement relaxed accessor macros as conditional wrappers Will Deacon
2014-09-25 10:32 ` Arnd Bergmann
2014-09-25 10:32 ` Arnd Bergmann
2014-09-25 10:38 ` Will Deacon
2014-09-25 10:38 ` Will Deacon
2014-09-25 10:43 ` Arnd Bergmann
2014-09-25 10:43 ` Arnd Bergmann
2014-09-25 11:44 ` Will Deacon
2014-09-25 11:44 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 02/17] microblaze: io: remove dummy relaxed accessor macros Will Deacon
2014-09-24 17:17 ` [PATCH v3 03/17] s390: io: remove dummy relaxed accessor macros for reads Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 04/17] xtensa: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-25 15:22 ` Max Filippov
2014-09-25 15:22 ` Max Filippov
2014-09-24 17:17 ` [PATCH v3 05/17] frv: io: implement dummy relaxed accessor macros for writes Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 06/17] cris: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 07/17] ia64: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 08/17] m32r: " Will Deacon
2014-09-24 17:17 ` [PATCH v3 09/17] m68k: " Will Deacon
2014-09-25 1:05 ` Greg Ungerer
2014-09-25 9:33 ` Will Deacon
2014-09-25 9:33 ` Will Deacon
2014-09-25 9:51 ` Geert Uytterhoeven [this message]
2014-09-25 9:51 ` Geert Uytterhoeven
2014-09-25 10:33 ` Will Deacon
2014-09-25 10:33 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 10/17] mn10300: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 11/17] parisc: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-25 20:00 ` Helge Deller
2014-09-24 17:17 ` [PATCH v3 12/17] powerpc: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 13/17] sparc: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 14/17] tile: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 15/17] x86: " Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-24 17:17 ` [PATCH v3 16/17] documentation: memory-barriers: clarify relaxed io accessor semantics Will Deacon
2014-09-24 17:17 ` [PATCH v3 17/17] asm-generic: io: define relaxed accessor macros unconditionally Will Deacon
2014-09-24 17:17 ` Will Deacon
2014-09-25 10:42 ` [PATCH v3 00/17] Cross-architecture definitions of relaxed MMIO accessors Arnd Bergmann
2014-09-25 13:15 ` Arnd Bergmann
2014-09-25 13:15 ` Arnd Bergmann
2014-09-25 14:55 ` Will Deacon
2014-09-25 14:55 ` Will Deacon
2014-09-25 15:07 ` Arnd Bergmann
2014-09-25 15:07 ` Arnd Bergmann
2014-09-25 15:15 ` Arnd Bergmann
2014-09-25 15:15 ` Arnd Bergmann
2014-09-25 15:24 ` Daniel Thompson
2014-09-25 15:24 ` Daniel Thompson
2014-09-25 19:17 ` Arnd Bergmann
2014-09-25 19:17 ` Arnd Bergmann
2014-09-25 20:17 ` Geert Uytterhoeven
2014-09-25 20:17 ` Geert Uytterhoeven
2014-09-26 8:40 ` Russell King - ARM Linux
2014-09-26 8:40 ` Russell King - ARM Linux
2014-09-26 9:28 ` Arnd Bergmann
2014-09-26 9:28 ` Arnd Bergmann
2014-09-26 8:05 ` Thierry Reding
2014-09-26 8:05 ` Thierry Reding
2014-09-26 13:39 ` Arnd Bergmann
2014-09-26 13:39 ` Arnd Bergmann
2014-09-26 13:46 ` Russell King - ARM Linux
2014-09-26 13:46 ` Russell King - ARM Linux
2014-09-26 21:36 ` Arnd Bergmann
2014-09-26 21:36 ` Arnd Bergmann
2014-09-29 8:23 ` Thierry Reding
2014-09-29 8:23 ` Thierry Reding
2014-09-29 9:50 ` Arnd Bergmann
2014-09-29 9:50 ` Arnd Bergmann
2014-10-01 15:23 ` Thierry Reding
2014-10-01 15:23 ` Thierry Reding
2014-10-01 18:34 ` Arnd Bergmann
2014-10-01 18:34 ` Arnd Bergmann
2014-09-29 9:25 ` Will Deacon
2014-09-29 9:25 ` Will Deacon
2014-09-29 9:48 ` Arnd Bergmann
2014-09-29 9:48 ` Arnd Bergmann
2014-10-30 16:59 ` Will Deacon
2014-10-30 16:59 ` Will Deacon
2014-10-30 20:04 ` Arnd Bergmann
2014-10-30 20:04 ` Arnd Bergmann
2014-10-31 11:09 ` Thierry Reding
2014-10-31 11:09 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdVpCs2RtsdDpdN3tp9_Xa1TzDMM3Z5+pP07B7Y3He2hLA@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=chris@zankel.net \
--cc=cmetcalf@tilera.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dhowells@redhat.com \
--cc=gerg@uclinux.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jcmvbkbc@gmail.com \
--cc=jesper.nilsson@axis.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rdunlap@infradead.org \
--cc=sam@ravnborg.org \
--cc=schwidefsky@de. \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).