From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Date: Wed, 6 Nov 2019 19:16:38 +0100 Message-ID: References: <20191029064834.23438-12-hch@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Palmer Dabbelt Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-m68k , Openrisc , Greentime Hu , MTD List-Id: linux-arch.vger.kernel.org Hi Palmer, On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > It looks like the difference in prototype between the architectures is between > > void __iomem *ioremap(resource_size_t, size_t) > void __iomem *ioremap(phys_addr_t, size_t) > void __iomem *ioremap(phys_addr_t, unsigned long) > void __iomem *ioremap(unsigned long, unsigned long) > > shouldn't they all just be that first one? In other words, wouldn't it be > better to always provide the generic ioremap prototype and unify the ports > instead? Agreed. But I'd go for the second one. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f68.google.com ([209.85.210.68]:34492 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727397AbfKFSQu (ORCPT ); Wed, 6 Nov 2019 13:16:50 -0500 MIME-Version: 1.0 References: <20191029064834.23438-12-hch@lst.de> In-Reply-To: From: Geert Uytterhoeven Date: Wed, 6 Nov 2019 19:16:38 +0100 Message-ID: Subject: Re: [PATCH 11/21] asm-generic: don't provide ioremap for CONFIG_MMU Content-Type: text/plain; charset="UTF-8" Sender: linux-arch-owner@vger.kernel.org List-ID: To: Palmer Dabbelt Cc: Christoph Hellwig , "linux-ia64@vger.kernel.org" , Linux-sh list , Linux Kernel Mailing List , Guo Ren , sparclinux , linux-riscv@lists.infradead.org, Vincent Chen , Linux-Arch , linux-s390 , "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , arcml , linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-m68k , Openrisc , Greentime Hu , MTD Maling List , Guan Xuetao , Linux ARM , Michal Simek , Parisc List , linux-mips@vger.kernel.org, alpha , nios2-dev@lists.rocketboards.org Message-ID: <20191106181638.MkcZbf06uXMHpAoFsTJYjEyuSHeNUXQAbeQ_yfa17yE@z> Hi Palmer, On Wed, Nov 6, 2019 at 7:11 PM Palmer Dabbelt wrote: > It looks like the difference in prototype between the architectures is between > > void __iomem *ioremap(resource_size_t, size_t) > void __iomem *ioremap(phys_addr_t, size_t) > void __iomem *ioremap(phys_addr_t, unsigned long) > void __iomem *ioremap(unsigned long, unsigned long) > > shouldn't they all just be that first one? In other words, wouldn't it be > better to always provide the generic ioremap prototype and unify the ports > instead? Agreed. But I'd go for the second one. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds