From mboxrd@z Thu Jan 1 00:00:00 1970 From: Geert Uytterhoeven Subject: sys_kcmp (was: Re: [PATCH 1/2] ARM: add finit_module syscall to ARM) Date: Sat, 22 Sep 2012 12:56:42 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Russell King Cc: Kees Cook , linux-kernel@vger.kernel.org, Linux-Arch , Heiko Carstens , Cyrill Gorcunov List-Id: linux-arch.vger.kernel.org On Fri, Sep 21, 2012 at 6:51 PM, Russell King wrote: > That brings up another question though - when was kcmp added to x86, and > why aren't we getting notifications from checksyscalls.sh that ARM hasn't > been updated? > > It seems to be that the script was broken, and no one has noticed. It seems Heiko did notice: http://www.serverphorums.com/read.php?12,559093 Now, I'm a bit puzzled by what follows: Heiko proposes a patch to ignore sys_kcmp, as it's x86-specific, which is acked by Cyrill. Then it suddenly switches to Heiko enabling it on s390 anyway? > commit 29dc54c673ea2531d589400badb4ada5f5f60dae > Author: H. Peter Anvin > Date: Fri Nov 11 15:57:53 2011 -0800 > > checksyscalls: Use arch/x86/syscalls/syscall_32.tbl as source > > Use the new arch/x86/syscalls/syscall_32.tbl file as source instead of > arch/x86/include/asm/unistd_32.h. > > Cc: Michal Marek > Cc: Geert Uytterhoeven > Cc: Sam Ravnborg > Signed-off-by: H. Peter Anvin > > is the culpret, more specifically this fragment: > > + echo < +#if !defined(__NR_${name}) && !defined(__IGNORE_${name}) > +#warning syscall ${name} not implemented > +#endif > +EOF > > "echo < above just generates a blank line for each entry in x86's syscalls_32.tbl, > resulting in the compiler doing no checking for us. > > That "echo < > :1220:2: warning: #warning syscall kcmp not implemented > > So, actually, I want to add this kcmp syscall _now_ into -rc which I'm > afraid will break your patch, and bump your syscall number on ARM to 379. With a CC to stable for v3.5? ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vb0-f46.google.com ([209.85.212.46]:47061 "EHLO mail-vb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752416Ab2IVK4n (ORCPT ); Sat, 22 Sep 2012 06:56:43 -0400 MIME-Version: 1.0 Date: Sat, 22 Sep 2012 12:56:42 +0200 Message-ID: Subject: sys_kcmp (was: Re: [PATCH 1/2] ARM: add finit_module syscall to ARM) From: Geert Uytterhoeven Content-Type: text/plain; charset=UTF-8 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Russell King Cc: Kees Cook , linux-kernel@vger.kernel.org, Linux-Arch , Heiko Carstens , Cyrill Gorcunov Message-ID: <20120922105642.VAI2AvQ8luY1vUZD0aQ-6Fnatewh8laqSEwI1zzAhDE@z> On Fri, Sep 21, 2012 at 6:51 PM, Russell King wrote: > That brings up another question though - when was kcmp added to x86, and > why aren't we getting notifications from checksyscalls.sh that ARM hasn't > been updated? > > It seems to be that the script was broken, and no one has noticed. It seems Heiko did notice: http://www.serverphorums.com/read.php?12,559093 Now, I'm a bit puzzled by what follows: Heiko proposes a patch to ignore sys_kcmp, as it's x86-specific, which is acked by Cyrill. Then it suddenly switches to Heiko enabling it on s390 anyway? > commit 29dc54c673ea2531d589400badb4ada5f5f60dae > Author: H. Peter Anvin > Date: Fri Nov 11 15:57:53 2011 -0800 > > checksyscalls: Use arch/x86/syscalls/syscall_32.tbl as source > > Use the new arch/x86/syscalls/syscall_32.tbl file as source instead of > arch/x86/include/asm/unistd_32.h. > > Cc: Michal Marek > Cc: Geert Uytterhoeven > Cc: Sam Ravnborg > Signed-off-by: H. Peter Anvin > > is the culpret, more specifically this fragment: > > + echo < +#if !defined(__NR_${name}) && !defined(__IGNORE_${name}) > +#warning syscall ${name} not implemented > +#endif > +EOF > > "echo < above just generates a blank line for each entry in x86's syscalls_32.tbl, > resulting in the compiler doing no checking for us. > > That "echo < > :1220:2: warning: #warning syscall kcmp not implemented > > So, actually, I want to add this kcmp syscall _now_ into -rc which I'm > afraid will break your patch, and bump your syscall number on ARM to 379. With a CC to stable for v3.5? ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds