From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Gortmaker Subject: Re: [PATCH 10/73] powerpc: use device_initcall for registering rtc devices Date: Tue, 21 Jan 2014 21:26:52 -0500 Message-ID: References: <1390339396-3479-1-git-send-email-paul.gortmaker@windriver.com> <1390339396-3479-11-git-send-email-paul.gortmaker@windriver.com> <1390348085.5027.18.camel@smoke> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1390348085.5027.18.camel@smoke> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Geoff Levand Cc: linux-arch , Paul Mackerras , linuxppc-dev@lists.ozlabs.org, LKML List-Id: linux-arch.vger.kernel.org On Tue, Jan 21, 2014 at 6:48 PM, Geoff Levand wrote: > Hi Paul, > > On Tue, 2014-01-21 at 16:22 -0500, Paul Gortmaker wrote: >> Currently these two RTC devices are in core platform code >> where it is not possible for them to be modular. It will >> never be modular, so using module_init as an alias for >> __initcall can be somewhat misleading. >> >> arch/powerpc/kernel/time.c | 2 +- >> arch/powerpc/platforms/ps3/time.c | 3 +-- >> 2 files changed, 2 insertions(+), 3 deletions(-) > > I tested the PS3 part of this patch and it seems to work OK. > > Acked-by: Geoff Levand Thanks Geoff for the review and testing; I'll add the ack. Paul. -- > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f52.google.com ([74.125.82.52]:45019 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752690AbaAVC1Y (ORCPT ); Tue, 21 Jan 2014 21:27:24 -0500 MIME-Version: 1.0 In-Reply-To: <1390348085.5027.18.camel@smoke> References: <1390339396-3479-1-git-send-email-paul.gortmaker@windriver.com> <1390339396-3479-11-git-send-email-paul.gortmaker@windriver.com> <1390348085.5027.18.camel@smoke> From: Paul Gortmaker Date: Tue, 21 Jan 2014 21:26:52 -0500 Message-ID: Subject: Re: [PATCH 10/73] powerpc: use device_initcall for registering rtc devices Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geoff Levand Cc: linux-arch , linuxppc-dev@lists.ozlabs.org, Paul Mackerras , LKML Message-ID: <20140122022652.1CVzgI_Ff-vGS_7keszIdkB1SmuYJ47VOCZYU2krFZo@z> On Tue, Jan 21, 2014 at 6:48 PM, Geoff Levand wrote: > Hi Paul, > > On Tue, 2014-01-21 at 16:22 -0500, Paul Gortmaker wrote: >> Currently these two RTC devices are in core platform code >> where it is not possible for them to be modular. It will >> never be modular, so using module_init as an alias for >> __initcall can be somewhat misleading. >> >> arch/powerpc/kernel/time.c | 2 +- >> arch/powerpc/platforms/ps3/time.c | 3 +-- >> 2 files changed, 2 insertions(+), 3 deletions(-) > > I tested the PS3 part of this patch and it seems to work OK. > > Acked-by: Geoff Levand Thanks Geoff for the review and testing; I'll add the ack. Paul. -- > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev