From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 638C4C7EE23 for ; Tue, 2 May 2023 14:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234396AbjEBOYq (ORCPT ); Tue, 2 May 2023 10:24:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41942 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234072AbjEBOYo (ORCPT ); Tue, 2 May 2023 10:24:44 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 564AB11A; Tue, 2 May 2023 07:24:43 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1aaebed5bd6so20628785ad.1; Tue, 02 May 2023 07:24:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683037483; x=1685629483; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=s1aeen3ZK+Eot6IC/oOTAkZg5Jx6a7diThkYUUdZei0=; b=o7eV6bV5rpKciv6EIj9ga4Omoc8JiajzV/SXD9s6GTpCIHwLsqIeUrnFZuC+xAIaiW WjEsJu1B2GKv/VlyiP9foiCAZE6F++nD+BWDCHQtjX8GXp25FXxTTDqEhJfEaCmCRZnW r/TojnhdtU1uIxMuMFFOdIT7Ow7MxYnqTZbrKtm4QgaRKGsCrFqUlZThCmVisJrJf8LM /bNVZ2wUIhggAaUQvPy2HmP3xLnCZxM2nh9Oy/B1JiqMdIiCPGs2rAsKMpXcHd+3R9I1 ZjnOJ4VKyNowo/00zxs8soF2kfewUpLu4llf08zWCp8MVLdUhOzj6mQ/SdBcj0q0dUoG ml+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683037483; x=1685629483; h=in-reply-to:references:cc:to:from:subject:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=s1aeen3ZK+Eot6IC/oOTAkZg5Jx6a7diThkYUUdZei0=; b=Vp2KYB/dVQooHRvtO8Cmoq54GsyIemxX5WZAWRDTGMc68kaMwhnuNGoPX44aT3f164 S1EHovAn8zb+glJD/iT73jrYOHem6dhdCJsb1/pYIj6wnQ3WJP3jP8INve/bPdR5qhNz L0etZk+4P5tNHF2lU7m5DN5rUBwhjn4n0gmgKzQQP6jSnNv9lw9hNEKm5W2i5FSiBACQ 1H3T6TAzfgWv1r/k6OzqhVnZXsXyaIcZTA+qOKD+0GRJukU8fBihYhSOrgFI0shA8812 MezhUACyIqj6PX/ZVFnPtkcBBR77OI1tqMLnvjjCBglVJDrQPPisvEnxW5JbcFdXlEhF 0t0A== X-Gm-Message-State: AC+VfDztUjedFvOFemq5vhf2EG6JFitV6VqzgCUuaXvQk0+eWmSlmDYX 4BE4f2wZm3Te0tRC7HqhWo0ot0ldkQLJWQ== X-Google-Smtp-Source: ACHHUZ7J8Aas1J2Rc20jnb1KGckFkPjq+j4uXL85mWslpQ5/EpkOpe4cYomHtpe0qtAoy+AsMW7sBg== X-Received: by 2002:a17:902:d349:b0:1a9:2823:dad3 with SMTP id l9-20020a170902d34900b001a92823dad3mr18355696plk.42.1683037482638; Tue, 02 May 2023 07:24:42 -0700 (PDT) Received: from localhost (118-208-214-188.tpgi.com.au. [118.208.214.188]) by smtp.gmail.com with ESMTPSA id x10-20020a170902b40a00b001ab05aaaf8fsm2012505plr.104.2023.05.02.07.24.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 07:24:41 -0700 (PDT) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 03 May 2023 00:24:24 +1000 Message-Id: Subject: Re: [PATCH] Remove HAVE_VIRT_CPU_ACCOUNTING_GEN option From: "Nicholas Piggin" To: "Palmer Dabbelt" Cc: "Arnd Bergmann" , , , , , , , , , , , , , , , , , , , , , , "Paul Walmsley" , , , , , , , , , , , , , , , , , , , , X-Mailer: aerc 0.14.0 References: <20230429063348.125544-1-npiggin@gmail.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Sun Apr 30, 2023 at 6:14 AM AEST, Palmer Dabbelt wrote: > On Fri, 28 Apr 2023 23:33:48 PDT (-0700), npiggin@gmail.com wrote: > > This option was created in commit 554b0004d0ec4 ("vtime: Add > > HAVE_VIRT_CPU_ACCOUNTING_GEN Kconfig") for architectures to indicate > > they support the 64-bit cputime_t required for VIRT_CPU_ACCOUNTING_GEN. > > > > The cputime_t type has since been removed, so this doesn't have any > > meaning. Remove it. > > > > Cc: linux-arch@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: Vineet Gupta > > Cc: linux-snps-arc@lists.infradead.org > > Cc: Brian Cain > > Cc: linux-hexagon@vger.kernel.org > > Cc: Huacai Chen > > Cc: loongarch@lists.linux.dev > > Cc: Geert Uytterhoeven > > Cc: linux-m68k@lists.linux-m68k.org > > Cc: Michal Simek > > Cc: Thomas Bogendoerfer > > Cc: linux-mips@vger.kernel.org > > Cc: Dinh Nguyen > > Cc: Jonas Bonn > > Cc: Stefan Kristiansson > > Cc: Stafford Horne > > Cc: linux-openrisc@vger.kernel.org > > Cc: "James E.J. Bottomley" > > Cc: Helge Deller > > Cc: linux-parisc@vger.kernel.org > > Cc: Paul Walmsley > > Cc: Palmer Dabbelt > > Cc: Albert Ou > > Cc: linux-riscv@lists.infradead.org > > Cc: Yoshinori Sato > > Cc: Rich Felker > > Cc: John Paul Adrian Glaubitz > > Cc: linux-sh@vger.kernel.org > > Cc: "David S. Miller" > > Cc: sparclinux@vger.kernel.org > > Cc: Richard Weinberger > > Cc: Anton Ivanov > > Cc: Johannes Berg > > Cc: linux-um@lists.infradead.org > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > Cc: Borislav Petkov > > Cc: Dave Hansen > > Cc: x86@kernel.org > > Cc: "H. Peter Anvin" > > Cc: Kevin Hilman > > Cc: Frederic Weisbecker > > Signed-off-by: Nicholas Piggin > > --- > > Hi, > > > > Could we tidy this? I don't know what tree it can go in, timers, > > sched, asm-generic, probably doesn't matter. > > > > The only thing this actually does is gate VIRT_CPU_ACCOUNTING_GEN and > > NO_HZ_FULL so if your arch has some other issue that requires this > > then the documentation needs to change. Any concerns from the archs? > > I.e., 32-bit that does *not* define HAVE_VIRT_CPU_ACCOUNTING_GEN > > which looks to be: > > > > arc > > hexagon > > loongarch 32-bit with SMP > > m68k > > microblaze > > mips 32-bit with SMP > > nios2 > > openrisc > > parisc 32-bit > > riscv 32-bit > > Nothing's jumping out, though I haven't tested this yet so I'm not 100%. = =20 > I assume this isn't aimed for this merge window, given the timing? =20 No, maybe the next one though. > Probably best to give this sort of thing time to bake in linux-next, but= =20 > I doubt anyone is even paying attention to rv32/NO_HZ_FULL so no big=20 > deal either way on my end. > > Acked-by: Palmer Dabbelt # RISC-V Thanks, Nick