* [PATCH 10/19] Kill ancient crap in s390 compat mmap
@ 2009-12-07 3:53 Al Viro
0 siblings, 0 replies; only message in thread
From: Al Viro @ 2009-12-07 3:53 UTC (permalink / raw)
To: linux-arch; +Cc: torvalds, linux-kernel
We've had TASK_SIZE set to 1<<31 for 31bit tasks since May 2004.
Before that old32_mmap() had to deal with do_mmap_pgoff() giving
it an address out of range. It had tried to do that by checking
return value and doing do_munmap() (at wrong address, BTW).
IOW, that code had been dead for 5.5 years (and bogus - for 8).
Kill.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
arch/s390/kernel/compat_linux.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/arch/s390/kernel/compat_linux.c b/arch/s390/kernel/compat_linux.c
index 0debcec..c5a9fba 100644
--- a/arch/s390/kernel/compat_linux.c
+++ b/arch/s390/kernel/compat_linux.c
@@ -701,11 +701,6 @@ static inline long do_mmap2(
down_write(¤t->mm->mmap_sem);
error = do_mmap_pgoff(file, addr, len, prot, flags, pgoff);
- if (!IS_ERR((void *) error) && error + len >= 0x80000000ULL) {
- /* Result is out of bounds. */
- do_munmap(current->mm, addr, len);
- error = -ENOMEM;
- }
up_write(¤t->mm->mmap_sem);
if (file)
--
1.5.6.5
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-07 3:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-07 3:53 [PATCH 10/19] Kill ancient crap in s390 compat mmap Al Viro
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).