public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Andrew Morton <akpm@linux-foundation.org>,
	Ulrich Drepper <drepper@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	davidel@xmailserver.org, linux-arch@vger.kernel.org,
	mtk.manpages@googlemail.com
Subject: Re: [patch 179/322] flag parameters add-on: remove epoll_create size param
Date: Sun, 10 Aug 2008 14:13:32 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0808101411490.10672@anakin> (raw)
In-Reply-To: <200807240429.m6O4ThGR029384@imap1.linux-foundation.org>

On Wed, 23 Jul 2008, akpm@linux-foundation.org wrote:
> Remove the size parameter from the new epoll_create syscall and renames the
> syscall itself.  The updated test program follows.
> 
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> #include <fcntl.h>
> #include <stdio.h>
> #include <time.h>
> #include <unistd.h>
> #include <sys/syscall.h>
> 
> #ifndef __NR_epoll_create2
			   ^
The test program still uses __NR_epoll_create2 instead of
__NR_epoll_create1 everywhere.

> diff -puN fs/eventpoll.c~flag-parameters-add-on-remove-epoll_create-size-param fs/eventpoll.c
> --- a/fs/eventpoll.c~flag-parameters-add-on-remove-epoll_create-size-param
> +++ a/fs/eventpoll.c
> @@ -1046,7 +1046,7 @@ retry:
>   * RB tree. With the current implementation, the "size" parameter is ignored
                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   * (besides sanity checks).
      ^^^^^^^^^^^^^^^^^^^^^^^
>   */
> -asmlinkage long sys_epoll_create2(int size, int flags)
> +asmlinkage long sys_epoll_create1(int flags)

The function comment was not updated for the removal of the `size'
parameter. Can you please fix that?

Thanks!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

  reply	other threads:[~2008-08-10 12:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-24  4:29 [patch 179/322] flag parameters add-on: remove epoll_create size param akpm
2008-08-10 12:13 ` Geert Uytterhoeven [this message]
2008-08-12  0:00   ` Andrew Morton
2008-08-12  6:51     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0808101411490.10672@anakin \
    --to=geert@linux-m68k.org \
    --cc=akpm@linux-foundation.org \
    --cc=davidel@xmailserver.org \
    --cc=drepper@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=mtk.manpages@googlemail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox