From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hugh Dickins Subject: Re: [PATCH] kill USE_ELF_CORE_DUMP Date: Sat, 26 Sep 2009 21:03:27 +0100 (BST) Message-ID: References: <20090423183331.GA19899@lst.de> <49F16786.7010401@petalogix.com> <20090926195010.GA24592@lst.de> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mk-filter-1-a-1.mail.uk.tiscali.com ([212.74.100.52]:42935 "EHLO mk-filter-1-a-1.mail.uk.tiscali.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbZIZUD1 (ORCPT ); Sat, 26 Sep 2009 16:03:27 -0400 In-Reply-To: <20090926195010.GA24592@lst.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Christoph Hellwig Cc: Michal Simek , linux-arch@vger.kernel.org, microblaze-uclinux@itee.uq.edu.au, linux-kernel@vger.kernel.org On Sat, 26 Sep 2009, Christoph Hellwig wrote: > Currently all architectures but microblaze unconditionally define > USE_ELF_CORE_DUMP. The microblaze ommision seems like an error to > me, so let's kill this ifdef and make sure we are the same everywhere. > > Signed-off-by: Christoph Hellwig Yes, I came to a similar conclusion when I added get_dump_page(): #ifdef'ed it on CONFIG_ELF_CORE, but couldn't see the point of USE_ELF_CORE_DUMP. (Though I missed the microblaze omission). Acked-by: Hugh Dickins