public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Stern <stern@rowland.harvard.edu>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: "Joel Fernandes" <joel@joelfernandes.org>,
	linux-kernel@vger.kernel.org, "Boqun Feng" <boqun.feng@gmail.com>,
	"Jade Alglave" <j.alglave@ucl.ac.uk>,
	"Luc Maranget" <luc.maranget@inria.fr>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Will Deacon" <will.deacon@arm.com>,
	"Jonas Oberhauser" <jonas.oberhauser@huaweicloud.com>,
	"Akira Yokosawa" <akiyks@gmail.com>,
	"Andrea Parri" <parri.andrea@gmail.com>,
	"Daniel Lustig" <dlustig@nvidia.com>,
	"David Howells" <dhowells@redhat.com>,
	"Jonas Oberhauser" <jonas.oberhauser@huawei.com>,
	linux-arch@vger.kernel.org, "Nicholas Piggin" <npiggin@gmail.com>,
	"Paul Heidekrüger" <paul.heidekrueger@in.tum.de>,
	"Will Deacon" <will@kernel.org>
Subject: Re: [PATCH] tools/memory-model: Add details about SRCU read-side critical sections
Date: Wed, 22 Feb 2023 15:32:12 -0500	[thread overview]
Message-ID: <Y/Z7zIGNUIxymLRO@rowland.harvard.edu> (raw)
In-Reply-To: <20230222195051.GT2948950@paulmck-ThinkPad-P17-Gen-1>

On Wed, Feb 22, 2023 at 11:50:51AM -0800, Paul E. McKenney wrote:
> On Mon, Feb 20, 2023 at 04:06:13PM -0500, Alan Stern wrote:
> > On Sun, Feb 19, 2023 at 12:13:14PM -0500, Joel Fernandes wrote:
> > > On Sun, Feb 19, 2023 at 12:11 PM Joel Fernandes <joel@joelfernandes.org> wrote:
> > > > Even though it may be redundant: would it be possible to also mention
> > > > (after this paragraph) that this case forms an undesirable "->rf" link
> > > > between B and C, which then causes us to link A and D as a result?
> > > >
> > > > A[srcu-lock] ->data B[once] ->rf C[once] ->data D[srcu-unlock].
> > > 
> > > Apologies, I meant here, care must be taken to avoid:
> > > 
> > > A[srcu-lock] ->data B[srcu-unlock] ->rf C[srcu-lock] ->data D[srcu-unlock].
> > 
> > Revised patch below.  I changed more than just this bit.  Mostly small 
> > edits to improve readability, but I did add a little additional 
> > material.
> 
> Looks good to me, thank you!
> 
> Would you like to send a formal patch, or are you thinking in terms
> of making other changes first?

I'll send a formal patch when I find time to write an appropriate 
Changelog description.

I also have in mind making other changes along the lines Joel suggested, 
but they will be separate patches.

Alan

  reply	other threads:[~2023-02-22 20:32 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  1:55 [PATCH] tools/memory-model: Add details about SRCU read-side critical sections Joel Fernandes (Google)
2023-02-19 16:48 ` Alan Stern
2023-02-19 17:11   ` Joel Fernandes
2023-02-19 17:13     ` Joel Fernandes
2023-02-20 21:06       ` Alan Stern
2023-02-21  0:58         ` Joel Fernandes
2023-02-22 19:50         ` Paul E. McKenney
2023-02-22 20:32           ` Alan Stern [this message]
2023-02-22 20:59             ` Paul E. McKenney
2023-02-23  2:36           ` [PATCH] tools/memory-model: Add documentation " Alan Stern
2023-02-23 19:54             ` Joel Fernandes
2023-02-24  2:32             ` Akira Yokosawa
2023-02-24  2:36               ` Alan Stern
2023-02-24 15:30               ` [PATCH v2] " Alan Stern
2023-02-24 18:39                 ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y/Z7zIGNUIxymLRO@rowland.harvard.edu \
    --to=stern@rowland.harvard.edu \
    --cc=akiyks@gmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=dlustig@nvidia.com \
    --cc=j.alglave@ucl.ac.uk \
    --cc=joel@joelfernandes.org \
    --cc=jonas.oberhauser@huawei.com \
    --cc=jonas.oberhauser@huaweicloud.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luc.maranget@inria.fr \
    --cc=npiggin@gmail.com \
    --cc=parri.andrea@gmail.com \
    --cc=paul.heidekrueger@in.tum.de \
    --cc=paulmck@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox