From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F99EC61DA4 for ; Wed, 22 Feb 2023 22:54:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229869AbjBVWyy (ORCPT ); Wed, 22 Feb 2023 17:54:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233086AbjBVWyw (ORCPT ); Wed, 22 Feb 2023 17:54:52 -0500 Received: from mail-pf1-x44a.google.com (mail-pf1-x44a.google.com [IPv6:2607:f8b0:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70A8337F0C for ; Wed, 22 Feb 2023 14:54:50 -0800 (PST) Received: by mail-pf1-x44a.google.com with SMTP id ds2-20020a056a004ac200b0058d9b9fecb6so4284443pfb.1 for ; Wed, 22 Feb 2023 14:54:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=t1rUxcsEzgzkuc81EHAiSJThwOfOiPUl0WEkc2IML/M=; b=p4sXIDbjE4Nc/nRU1X8iV1XYE4jomrb+UJhtC7J+xEm7INBfiDn27gs/eoHnGlzmRT 92NbvCgseDZ0JsQv3XF/gwcMtKevWDZckWffhhm1iVJQBk+R5lUHI6CKSOloHvmr5SXD BvdY7F8b50dcNqhHzIYk3cub1ZEBEA8+kXj+nWZ5dvUznAb22X/ufd/HOqJW5U4x5C4B JQ1TG20xtnMqed4yXHC4Ock+whPxUyHQMHZjkt/JIt8uxh8Qe/UOObrTwEnXqaCLC3js c4oFz5cV9DaUM/VtN6S58luTPLE4WRjwkm5QlSNnfO16B01aCPeJv7rypyvXDzgyxkMp sLnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t1rUxcsEzgzkuc81EHAiSJThwOfOiPUl0WEkc2IML/M=; b=4iB1wLjzZveYV46jl9pzcIkSoGcNuQWMEpxvrUSeE6qbF7hjuZvwMEpop6NvltYCKd 2SkoVQ05ojZQ3Whm+p2/dMFZ+mkERqr6Nv5+2GcS1k4zgTjmFzolb/8Zsg//KXc6RncA sTu3/Xp2btRKlcAn5Lny+EO8SFpguvM8JzrKIb6PUYNbot77WXcz9Bk8kHMhFAmNXmJ2 dEU+95RUSPJJT0QzSQxcEpIzucwjJnrtbOiMcjHLfmzPdxdAOAY5F5MxyVTUeqXRd7Tr IdkfNDh9x5ielRCsy+ymo6dSnTAYiQ/fSvFZJCvQJL5FHqi5Q8AWMA38EYMCh4R4waWY 02Iw== X-Gm-Message-State: AO0yUKWRcOr3EX731MSrW7R8S6DlJd9n+ur5jYJrjfcg3NN8hlrMzXTP 96/2rpcBOJDtc47N/9g8xJS4hbPqgC0= X-Google-Smtp-Source: AK7set/sQOffs0k3s7KounKG129lsIZ65HRvR+ia/A/0i253S1K0NbH2/JiaGq46cARK3kvQ+iKylGsp5hE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a62:864e:0:b0:5d6:4f73:9ad with SMTP id x75-20020a62864e000000b005d64f7309admr454083pfd.2.1677106489373; Wed, 22 Feb 2023 14:54:49 -0800 (PST) Date: Wed, 22 Feb 2023 14:54:47 -0800 In-Reply-To: Mime-Version: 1.0 References: Message-ID: Subject: Re: [PATCH v5 06/14] x86/ioremap: Support hypervisor specified range to map as encrypted From: Sean Christopherson To: Borislav Petkov Cc: "Michael Kelley (LINUX)" , Dave Hansen , "hpa@zytor.com" , KY Srinivasan , Haiyang Zhang , "wei.liu@kernel.org" , Dexuan Cui , "luto@kernel.org" , "peterz@infradead.org" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "lpieralisi@kernel.org" , "robh@kernel.org" , "kw@linux.com" , "bhelgaas@google.com" , "arnd@arndb.de" , "hch@lst.de" , "m.szyprowski@samsung.com" , "robin.murphy@arm.com" , "thomas.lendacky@amd.com" , "brijesh.singh@amd.com" , "tglx@linutronix.de" , "mingo@redhat.com" , "dave.hansen@linux.intel.com" , Tianyu Lan , "kirill.shutemov@linux.intel.com" , "sathyanarayanan.kuppuswamy@linux.intel.com" , "ak@linux.intel.com" , "isaku.yamahata@intel.com" , "dan.j.williams@intel.com" , "jane.chu@oracle.com" , "tony.luck@intel.com" , "x86@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-pci@vger.kernel.org" , "linux-arch@vger.kernel.org" , "iommu@lists.linux.dev" Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, Feb 22, 2023, Borislav Petkov wrote: > On Wed, Feb 22, 2023 at 02:13:44PM -0800, Sean Christopherson wrote: > > Because vTOM is a hardware feature, whereas the IO-APIC and vTPM being accessible > > via private memory are software features. It's very possible to emulate the > > IO-APIC in trusted code without vTOM. > > I know, but their use case is dictated by the fact that they're using > a SNP guest *with* vTOM as a SEV feature. And so their guest does > IO-APIC and vTPM *with* the vTOM SEV feature. That's what I'm trying to > model. Why? I genuinely don't understand the motivation for bundling all of this stuff under a single "feature". To me, that's like saying Haswell or Zen2 is a "feature", but outside of a very few cases where the exact uarch truly matters, nothing pivots on FMS because the CPU type is not a single feature.