From: Baoquan He <bhe@redhat.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"hch@infradead.org" <hch@infradead.org>,
"agordeev@linux.ibm.com" <agordeev@linux.ibm.com>,
"wangkefeng.wang@huawei.com" <wangkefeng.wang@huawei.com>,
"schnelle@linux.ibm.com" <schnelle@linux.ibm.com>,
"David.Laight@aculab.com" <David.Laight@aculab.com>,
"shorne@gmail.com" <shorne@gmail.com>
Subject: Re: [RFC PATCH 0/8] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way (Alternative)
Date: Wed, 19 Oct 2022 08:25:42 +0800 [thread overview]
Message-ID: <Y09EBgoqPGy2A5WL@MiWiFi-R3L-srv> (raw)
In-Reply-To: <fd7aa861-a85a-cc6d-df62-6e5e9a1b3149@csgroup.eu>
On 10/17/22 at 05:06pm, Christophe Leroy wrote:
> Hi Baoquan,
>
> Le 17/10/2022 à 02:37, Baoquan He a écrit :
> > Hi Christophe,
> >
> > On 10/12/22 at 12:09pm, Christophe Leroy wrote:
> >> From:
> >>
> >> As proposed in the discussion related to your series, here comes an
> >> exemple of how it could be.
> >>
> >> I have taken it into ARC and IA64 architectures as an exemple. This is
> >> untested, even not compiled, it is just to illustrated my meaning in the
> >> discussion.
> >>
> >> I also added a patch for powerpc architecture, that one in tested with
> >> both pmac32_defconfig and ppc64_le_defconfig.
> >>
> >> From my point of view, this different approach provide less churn and
> >> less intellectual disturbance than the way you do it.
> >
> > Yes, I agree, and admire your insistence on the thing you think right or
> > better. Learn from you.
> >
> > When you suggested this in my v2 post, I made a draft patch at below link
> > according to your suggestion to request people to review. What worried
> > me is that I am not sure it's ignored or disliked after one week of
> > waiting.
> >
> > https://lore.kernel.org/all/YwtND%2FL8xD+ViN3r@MiWiFi-R3L-srv/#related
> >
> > Up to now, seems people don't oppose this generic_ioremap_prot() way, we
> > can take it. So what's your plan? You want me to continue with your
> > patches wrapped in, or I can leave it to you if you want to take over?
>
> I don't plan to steal your work. If you feel confortable with my
> proposal, feel free to continue with it and amplify it. You have done
> most of the job, you have a clear view of all subtilities in the
> different architectures, so please continue, I don't plan to take over
> the good work you've done until now.
>
> The only purpose of my series was to illustrate my comments and convince
> myself it was a possible way, nothing more.
Thanks a lot for all these you have done, I will post another version with
the introducing generic_ioremap_prot() way you suggesed.
prev parent reply other threads:[~2022-10-19 0:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 10:09 [RFC PATCH 0/8] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way (Alternative) Christophe Leroy
2022-10-12 10:09 ` [RFC PATCH 1/8] hexagon: mm: Convert to GENERIC_IOREMAP Christophe Leroy
2022-10-12 10:09 ` [RFC PATCH 2/8] openrisc: mm: remove unneeded early ioremap code Christophe Leroy
2022-10-12 16:47 ` Stafford Horne
2022-10-12 10:09 ` [RFC PATCH 3/8] mm/ioremap: Define generic_ioremap_prot() and generic_iounmap() Christophe Leroy
2022-10-16 8:14 ` Alexander Gordeev
2022-10-16 16:54 ` Christophe Leroy
2022-10-12 10:09 ` [RFC PATCH 4/8] mm: ioremap: allow ARCH to have its own ioremap definition Christophe Leroy
2022-10-12 10:09 ` [RFC PATCH 5/8] arc: mm: Convert to GENERIC_IOREMAP Christophe Leroy
2022-10-12 10:09 ` [RFC PATCH 6/8] ia64: " Christophe Leroy
2022-10-12 10:09 ` [RFC PATCH 7/8] mm/ioremap: Consider IOREMAP space in generic ioremap Christophe Leroy
2022-10-12 10:39 ` Arnd Bergmann
2022-10-16 7:54 ` Alexander Gordeev
2022-10-16 11:51 ` Arnd Bergmann
2022-10-16 16:56 ` Christophe Leroy
2022-10-17 12:50 ` Michael Ellerman
2022-10-17 20:52 ` Arnd Bergmann
2022-10-12 10:09 ` [RFC PATCH 8/8] powerpc: mm: Convert to GENERIC_IOREMAP Christophe Leroy
2022-10-17 0:37 ` [RFC PATCH 0/8] mm: ioremap: Convert architectures to take GENERIC_IOREMAP way (Alternative) Baoquan He
2022-10-17 17:06 ` Christophe Leroy
2022-10-19 0:25 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y09EBgoqPGy2A5WL@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=David.Laight@aculab.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=hch@infradead.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=schnelle@linux.ibm.com \
--cc=shorne@gmail.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).