Re: [PATCH v3 18/37] mm: Add guard pages around a shadow stack.

Peter Zijlstra
2022-11-15T20:57:25Z

On Tue, Nov 15, 2022 at 08:40:19PM +0000, Edgecombe, Rick P wrote:
> > > +unsigned long __weak stack_guard_start_gap(struct vm_area_struct
> > > *vma)
> > > +{
> > > + if (vma->vm_flags & VM_GROWSDOWN)
> > > + return stack_guard_gap;
> > > + return 0;
> > > +}
> >
> > I'm thinking perhaps this wants to be an inline function?
>
> I don't think it can work with weak then.

That was kinda the point, __weak sucks and this is very small in any
case.