Re: [PATCH v3 04/37] x86/cpufeatures: Enable CET CR4 bit for shadow stack

Edgecombe, Rick P
2022-11-07T19:33:42Z

On Mon, 2022-11-07 at 20:30 +0100, Borislav Petkov wrote:
> On Mon, Nov 07, 2022 at 07:19:21PM +0000, Edgecombe, Rick P wrote:
> > There was at one point, but there was a suggestion to remove in
> > favor
> > of clearcpuid. I can add it back.
>
> Sounds like I need to school that "suggestor" about clearcpuid. :)
>
> For example, when doing this:
>
> 1625c833db93 ("x86/cpu: Allow feature bit names from /proc/cpuinfo
> in clearcpuid=")
>
> I even managed to prevent the kernel from booting. So clearcpuid= is
> definitely not for general consumption.
>
> So as said, please remove it from your whole patchset's text.

Will do, thanks.