From: Christoph Hellwig <hch@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: akpm@linux-foundation.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
arnd@arndb.de
Subject: Re: [PATCH] Decouple build from userspace headers
Date: Wed, 14 Jul 2021 15:22:08 +0100 [thread overview]
Message-ID: <YO7zEFNSXOY8pKCQ@infradead.org> (raw)
In-Reply-To: <YO3txvw87MjKfdpq@localhost.localdomain>
> -#define signals_blocked false
> +#define signals_blocked 0
Why can't we get at the kernel definition of false here?
> new file mode 100644
> --- /dev/null
> +++ b/include/stdarg.h
> @@ -0,0 +1,9 @@
> +#ifndef _LINUX_STDARG_H
> +#define _LINUX_STDARG_H
> +typedef __builtin_va_list __gnuc_va_list;
> +typedef __builtin_va_list va_list;
> +#define va_start(v, l) __builtin_va_start(v, l)
> +#define va_end(v) __builtin_va_end(v)
> +#define va_arg(v, T) __builtin_va_arg(v, T)
> +#define va_copy(d, s) __builtin_va_copy(d, s)
> +#endif
Empty lines before and after the include guards would be nice.
What do we need the __gnuc_va_list typedef for?
Otherwise this looks great. As a follow on maybe move the new header
to <linux/stdarg.h> to make clear to everyone that we are using our
own version.
next prev parent reply other threads:[~2021-07-14 14:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 19:47 [PATCH] Decouple build from userspace headers Alexey Dobriyan
2021-07-14 4:54 ` Masahiro Yamada
2021-07-14 8:42 ` Alexey Dobriyan
2021-07-14 14:22 ` Christoph Hellwig [this message]
2021-07-14 15:54 ` Alexey Dobriyan
2021-07-14 15:56 ` Christoph Hellwig
2021-07-14 17:16 ` Alexey Dobriyan
2021-07-14 17:45 ` [PATCH v2] " Alexey Dobriyan
2021-07-15 21:15 ` [PATCH -mm] fixup "Decouple build from userspace headers" Alexey Dobriyan
2021-07-18 12:36 ` Masahiro Yamada
2021-07-18 13:05 ` Masahiro Yamada
2021-07-16 9:03 ` [PATCH v2] Decouple build from userspace headers Anders Roxell
2021-07-16 10:10 ` Alexey Dobriyan
2021-07-16 13:04 ` Anders Roxell
2021-07-18 13:11 ` Masahiro Yamada
2021-07-20 16:13 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO7zEFNSXOY8pKCQ@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).