From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8809AC433FE for ; Thu, 24 Feb 2022 16:08:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229487AbiBXQIj (ORCPT ); Thu, 24 Feb 2022 11:08:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42592 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230382AbiBXQId (ORCPT ); Thu, 24 Feb 2022 11:08:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12E6E17EDA1; Thu, 24 Feb 2022 08:07:51 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 329D76179C; Thu, 24 Feb 2022 16:04:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87D2AC340EC; Thu, 24 Feb 2022 16:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645718654; bh=jWymqgAfcR3qfS82nYoUUc+s4THWcAw77Lv/fLqZeHs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VabpdoNHIcm5/kDkYE0JsGzkAuL1Vu3lh9leQX9oYtKdf1JOHFzhmjAHgUrLuH+pa pE8tAwzkQ3Mfe/q0S1NpFUDifbW3oA9eosOKPtqHxhm2VxX4MA79dbR4JGTzG+Kmqa 56eTw1xPUqlWsvKSMgpE9LMQ7kKsYS3gBpaJ2CRAgNnQFz6tIAwBenWIdSPGHbv0em rc+plY3fkKWk/6EcaT9eOxEgzSimHWjGKgGIfRjoBJ5fpLJ1KsJJHjOTQvQSB8V9cs LDulc5OVBeKGu+zXjQw75iauwMAwvQUEy/E/94fNp8HvQCYgbQW/io6nXvDGtR+sJa dOA6jaultOxgg== Date: Thu, 24 Feb 2022 09:04:08 -0700 From: Nathan Chancellor To: Linus Torvalds Cc: Arnd Bergmann , Jakob , Linux Kernel Mailing List , linux-arch , Greg Kroah-Hartman , Thomas Gleixner , Andy Shevchenko , Andrew Morton , Kees Cook , Mike Rapoport , "Gustavo A. R. Silva" , Brian Johannesmeyer , Cristiano Giuffrida , "Bos, H.J." , llvm@lists.linux.dev Subject: Re: [RFC PATCH 03/13] usb: remove the usage of the list iterator after the loop Message-ID: References: <20220217184829.1991035-1-jakobkoschel@gmail.com> <20220217184829.1991035-4-jakobkoschel@gmail.com> <6DFD3D91-B82C-469C-8771-860C09BD8623@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, Feb 23, 2022 at 01:53:39PM -0800, Linus Torvalds wrote: > On Wed, Feb 23, 2022 at 1:46 PM Arnd Bergmann wrote: > > > > > Ok, so we should be able to basically convert '--std=gnu89' into > > > '--std=gnu11 -Wno-shift-negative-value' with no expected change of > > > behavior. > > > > Yes, I think that is correct. > > Ok, somebody please remind me, and let's just try this early in the > 5.18 merge window. > > Because at least for me, doing > > - -std=gnu89 > + -std=gnu11 -Wno-shift-negative-value > > for KBUILD_CFLAGS works fine both in my gcc and clang builds. But > that's obviously just one version of each. I ran that diff through my set of clang builds on v5.17-rc5-21-g23d04328444a and only found one issue: https://github.com/ClangBuiltLinux/linux/issues/1603 I think that should be fixed on the clang side. Once it is, I think we could just disable that warning in those translation units for older versions of clang to keep the status quo. Cheers, Nathan