From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6638FC433EF for ; Wed, 23 Mar 2022 16:18:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233715AbiCWQUO (ORCPT ); Wed, 23 Mar 2022 12:20:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238855AbiCWQUM (ORCPT ); Wed, 23 Mar 2022 12:20:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8784C59A65; Wed, 23 Mar 2022 09:18:41 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2390C6184B; Wed, 23 Mar 2022 16:18:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 04A62C340E8; Wed, 23 Mar 2022 16:18:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1648052320; bh=xmssCclpuXkvokPOIc8kA2TpF6hDPr1nfNP2UJCwIVc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kQDEhbn2dsQ+pF3/zFmCMhiRAPwUL9hr3vakvVKREmueBHXYPPkGc1Yjk77g1+upO lsDQg0C3crQmPNkuUwYh3N5/NCPu7xCYzLRLkINXEPhXo6X4YJjVbQqoAXsUk9wZ3M Nph/NkDtXZQ3cUm86JAvalrgq86oea+2tvOlDFHw7B8O56nOXfcl0t6rQ0d6AY4qwA IadGNCw72DxDcmz7wQcxJVg1G9vsRI9GsUIHs91zDchMl/QMSewj0sA6+BEoIVeyXh T7p/CRUlVXHmloiINmMA/7xJ6LVM8pjEqYnS63qXXzPUgIkiBU7MrJsgohHJmDkTAQ /q/OmoZUIiA7g== Date: Wed, 23 Mar 2022 16:18:31 +0000 From: Mark Brown To: Arnd Bergmann Cc: Guenter Roeck , "Jason A. Donenfeld" , Linux Kernel Mailing List , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-arch , Dinh Nguyen , Nick Hu , Max Filippov , Palmer Dabbelt , "David S . Miller" , Yoshinori Sato , Michal Simek , Borislav Petkov , Guo Ren , Geert Uytterhoeven , Joshua Kinard , David Laight , Dominik Brodowski , Eric Biggers , Ard Biesheuvel , Thomas Gleixner , Andy Lutomirski , Kees Cook , Lennart Poettering , Konstantin Ryabitsev , Linus Torvalds , Greg Kroah-Hartman , Theodore Ts'o Subject: Re: [PATCH v1] random: block in /dev/urandom Message-ID: References: <20220217162848.303601-1-Jason@zx2c4.com> <20220322155820.GA1745955@roeck-us.net> <0d20fb04-81b8-eeee-49ab-5b0a9e78c9f8@roeck-us.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rbHr+yLemIUaUxTK" Content-Disposition: inline In-Reply-To: X-Cookie: Nice guys get sick. Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org --rbHr+yLemIUaUxTK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 23, 2022 at 04:53:13PM +0100, Arnd Bergmann wrote: > On Wed, Mar 23, 2022 at 3:23 PM Guenter Roeck wrote: > > I don't think it is entirely academic. versatile-pb fails for me; > > if it doesn't fail at KernelCI, I'd like to understand why - not to > > fix it in my test environment, but to make sure that I _don't_ fix it. > > After all, it _is_ a regression. Even if that regression is triggered > > by bad (for a given definition of "bad") userspace code, it is still > > a regression. > Maybe kernelci has a virtio-rng device assigned to the machine > and you don't? That would clearly avoid the issue here. No, nothing I can see in the boot log: https://storage.kernelci.org/next/master/next-20220323/arm/versatile_defcon= fig/gcc-10/lab-baylibre/baseline-qemu_arm-versatilepb.html and I'd be surprised if virtio devices made it through with a specific platform emulation. However it looks like for that test the init scripts didn't do anything with the random seed (possibly due to running =66rom ramdisk?) so we'd not have hit the condition. --rbHr+yLemIUaUxTK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmI7SFYACgkQJNaLcl1U h9DyDgf/U3gmBBfzqO9p6NhtOGB/g28xQ3p6y1kJ4Sg2NhFwA6wgeFfZE8b8k9Ps 4Fra0rZ5ps4ygGLxhk0sD0yHMtRlFP95ybscWVOP/hEDxqDOzqTwAZ5zbYAgyIxS a1hKm0AbnEmEpXyK7AhxHXsl3stNSqzCY9OFhJgMFekKkv7L3CAdrBUQCxZhfnKr obsPPejMdrEI5IX1ge4QCq9HFI0ohwRDaINOHWXGAX1p4+s6OwFjxvmzZZA87DPs OCApFRP6IbCHGqiIykL0UsxWZ6qDRdjLqnCaAK6N5+ZnrP13/C4O3M+dCxV8Vfx6 Y/3OlG3UrMouJEWe/iwV0bq4UdP6wA== =FAu8 -----END PGP SIGNATURE----- --rbHr+yLemIUaUxTK--