From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C8D9C433FE for ; Mon, 4 Apr 2022 21:28:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382520AbiDDVal (ORCPT ); Mon, 4 Apr 2022 17:30:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379545AbiDDR3I (ORCPT ); Mon, 4 Apr 2022 13:29:08 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0617031909 for ; Mon, 4 Apr 2022 10:27:11 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id u14so5600661pjj.0 for ; Mon, 04 Apr 2022 10:27:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=VYvPl145gx1NnQ2E3OJKFVQPxapHGXttn5rOGVj8YXo=; b=hd+vUeBK2jke4Z79gSu5EYlGJK/30+8ZPm5vusOwihjccMo+JYQaFziQAAtCID0e5b qiLbaSXJpB5nRDykwDoLmPmHeyaA4U3mO1aNEDIrpBI1y7KWpUIIYaKFkz1sQOFACAOc aM6lCqWr9wZwWsklSOxLwTatnC3eKJ1E18Cyxx8CEA5zLgAe9sm4oTFjzF7SzNxlrSY7 5YCfCpDy23ULHUPSewKuWau9wE833jCsfozeqx9dNss7+g86jPjfaK+eh0C/KKY3VLXw f3jp5vi8jNmhQOZlIPVusBowj6XA96wM7engEJdtxH6nw+nNIUhWc7hzzmvwmP0aO5k+ ThIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=VYvPl145gx1NnQ2E3OJKFVQPxapHGXttn5rOGVj8YXo=; b=LpW+N1zj+I9cl1t8bzATJhmVYia93xQGLy1QhmynvKiC+6MMAzFMwUU6OFboSe5eF2 l2Jr0sI50iF8cbsVbyKIIwxjE0+FFTOziT1XMdbFTUr7+2Yz59kT+xv7KHVFOAYrcWBp eyU3yDMBE7tNV99QfxLuUoltyW8hCtHLoWaVCHTI+PzNjvJu3NtYbFlA7I7YhMI/PXOR CGkT/OCV/q6n8BhaVpSTFNkS9xe7LTqSDtveaGilti4U7iNbNL4iDcESbtASaSIorE8Z rYHuRRu8NVfisiNYjmTqXn480PzH60nv4Y+eKfgr4JIv9cFAKtRXOIsL96+CshMnEdBK 8Dag== X-Gm-Message-State: AOAM532yJjhHewh/2y7cD0l8UVIz2WkGKpDmRHPONlKKMklKPhgaLNFB 3jeYEpPF2+r3AHZ//AJf11Gtjg== X-Google-Smtp-Source: ABdhPJzIn8VUPSw0kXUgBANdTlP1KbT/bIOfaGMgMZZeENIi+FbBiFh+hZ3dFMto7+s4V24GWdOQ6w== X-Received: by 2002:a17:90b:1c07:b0:1c7:5324:c68e with SMTP id oc7-20020a17090b1c0700b001c75324c68emr255680pjb.202.1649093231294; Mon, 04 Apr 2022 10:27:11 -0700 (PDT) Received: from google.com ([2620:15c:211:202:9d5:9b93:ffb4:574a]) by smtp.gmail.com with ESMTPSA id gt14-20020a17090af2ce00b001c701e0a129sm73834pjb.38.2022.04.04.10.27.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 10:27:09 -0700 (PDT) Date: Mon, 4 Apr 2022 10:27:02 -0700 From: Nick Desaulniers To: Masahiro Yamada Cc: Arnd Bergmann , linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/8] agpgart.h: do not include from exported header Message-ID: References: <20220404061948.2111820-1-masahiroy@kernel.org> <20220404061948.2111820-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220404061948.2111820-2-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, Apr 04, 2022 at 03:19:41PM +0900, Masahiro Yamada wrote: > Commit 35d0f1d54ecd ("include/uapi/linux/agpgart.h: include stdlib.h in > userspace") included to fix the unknown size_t error, but > I do not think it is the right fix. > > This header already uses __kernel_size_t a few lines below. > > Replace the remaining size_t, and stop including . > > Signed-off-by: Masahiro Yamada Thanks for the patch. Reviewed-by: Nick Desaulniers > --- > > include/uapi/linux/agpgart.h | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/include/uapi/linux/agpgart.h b/include/uapi/linux/agpgart.h > index f5251045181a..9cc3448c0b5b 100644 > --- a/include/uapi/linux/agpgart.h > +++ b/include/uapi/linux/agpgart.h > @@ -52,7 +52,6 @@ > > #ifndef __KERNEL__ > #include > -#include > > struct agp_version { > __u16 major; > @@ -64,10 +63,10 @@ typedef struct _agp_info { > __u32 bridge_id; /* bridge vendor/device */ > __u32 agp_mode; /* mode info of bridge */ > unsigned long aper_base;/* base of aperture */ > - size_t aper_size; /* size of aperture */ > - size_t pg_total; /* max pages (swap + system) */ > - size_t pg_system; /* max pages (system) */ > - size_t pg_used; /* current pages used */ > + __kernel_size_t aper_size; /* size of aperture */ > + __kernel_size_t pg_total; /* max pages (swap + system) */ > + __kernel_size_t pg_system; /* max pages (system) */ > + __kernel_size_t pg_used; /* current pages used */ > } agp_info; > > typedef struct _agp_setup { > -- > 2.32.0 >