From: Nathan Chancellor <nathan@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
x86@kernel.org, linux-arch@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] init/Kconfig: Remove USELIB syscall by default
Date: Tue, 12 Apr 2022 14:48:38 -0700 [thread overview]
Message-ID: <YlXztpgTxmn29KF3@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220412212519.4113845-1-keescook@chromium.org>
On Tue, Apr 12, 2022 at 02:25:20PM -0700, Kees Cook wrote:
> The uselib syscall has been long deprecated. There's no need to keep
> this enabled by default under X86_32.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
The 'bool "" + def_bool' was weird and I had to look up what libc5 even
was :)
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
> ---
> init/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index ddcbefe535e9..5cddb9ba0eef 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -435,8 +435,8 @@ config CROSS_MEMORY_ATTACH
> See the man page for more details.
>
> config USELIB
> - bool "uselib syscall"
> - def_bool ALPHA || M68K || SPARC || X86_32 || IA32_EMULATION
> + bool "uselib syscall (for libc5 and earlier)"
> + default ALPHA || M68K || SPARC
> help
> This option enables the uselib syscall, a system call used in the
> dynamic linker from libc5 and earlier. glibc does not use this
> --
> 2.32.0
>
prev parent reply other threads:[~2022-04-12 23:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 21:25 [PATCH] init/Kconfig: Remove USELIB syscall by default Kees Cook
2022-04-12 21:48 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlXztpgTxmn29KF3@dev-arch.thelio-3990X \
--to=nathan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox