From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31450C433FE for ; Wed, 27 Apr 2022 12:28:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233963AbiD0McA (ORCPT ); Wed, 27 Apr 2022 08:32:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233952AbiD0McA (ORCPT ); Wed, 27 Apr 2022 08:32:00 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A6FA3CFE1; Wed, 27 Apr 2022 05:28:49 -0700 (PDT) Received: from zn.tnic (p5de8eeb4.dip0.t-ipconnect.de [93.232.238.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 03CBC1EC0535; Wed, 27 Apr 2022 14:28:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1651062524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=aKBRkdcOUK2pnp+vQSbUvbTqtIXnLKj0VJmSDmt7oC0=; b=NHfKIFQJ+SZeRMFRR7iG7AvrorZ4sGeAQW951IHLqZGiIhH8xsnL4MEoCvZdO988HVhjCs QiJ/yZkmdzpdCcjdb2XM/Jk4CwXtZtIij26TQdC9Zn+whgo9bcaGJcoQKIQwADOIUE7sTC lJ/9+OjkWEUKJjYRxqSk5MOYidSpSXw= Date: Wed, 27 Apr 2022 14:28:44 +0200 From: Borislav Petkov To: Juergen Gross , Tom Lendacky Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-hyperv@vger.kernel.org, virtualization@lists.linux-foundation.org, Arnd Bergmann , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Andy Lutomirski , Peter Zijlstra , "Michael S. Tsirkin" , Jason Wang , Christoph Hellwig , Oleksandr Tyshchenko Subject: Re: [PATCH 2/2] virtio: replace arch_has_restricted_virtio_memory_access() Message-ID: References: <20220426134021.11210-1-jgross@suse.com> <20220426134021.11210-3-jgross@suse.com> <1c1a4a7d-a273-c3b0-3683-195f6e09a027@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1c1a4a7d-a273-c3b0-3683-195f6e09a027@suse.com> Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, Apr 27, 2022 at 08:37:31AM +0200, Juergen Gross wrote: > On 26.04.22 19:35, Borislav Petkov wrote: > > On Tue, Apr 26, 2022 at 03:40:21PM +0200, Juergen Gross wrote: > > > /* protected virtualization */ > > > static void pv_init(void) > > > { > > > if (!is_prot_virt_guest()) > > > return; > > > + platform_set_feature(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); > > > > Kinda long-ish for my taste. I'll probably call it: > > > > platform_set() > > > > as it is implicit that it sets a feature bit. > > Okay, fine with me. > > > > > > diff --git a/arch/x86/mm/mem_encrypt_identity.c b/arch/x86/mm/mem_encrypt_identity.c > > > index b43bc24d2bb6..6043ba6cd17d 100644 > > > --- a/arch/x86/mm/mem_encrypt_identity.c > > > +++ b/arch/x86/mm/mem_encrypt_identity.c > > > @@ -40,6 +40,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > #include > > > @@ -566,6 +567,10 @@ void __init sme_enable(struct boot_params *bp) > > > } else { > > > /* SEV state cannot be controlled by a command line option */ > > > sme_me_mask = me_mask; > > > + > > > + /* Set restricted memory access for virtio. */ > > > + platform_set_feature(PLATFORM_VIRTIO_RESTRICTED_MEM_ACCESS); > > > > Huh, what does that have to do with SME? > > I picked the function where sev_status is being set, as this seemed to be > the correct place to set the feature bit. What I don't understand is what does restricted memory access have to do with AMD SEV and how does play together with what you guys are trying to do? The big picture pls. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette