From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>,
"Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
Linux-Arch <linux-arch@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] asm-generic/io.h: rework split ioread64/iowrite64 helpers
Date: Thu, 27 Feb 2025 17:20:14 +0200 [thread overview]
Message-ID: <Z8CCrqzCfwzIpJ-3@smile.fi.intel.com> (raw)
In-Reply-To: <20250227141910.3819351-1-arnd@kernel.org>
On Thu, Feb 27, 2025 at 03:19:01PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> There are two incompatible sets of definitions of these eight functions:
> On 64-bit architectures setting CONFIG_HAS_IOPORT, they turn into
> either pair of 32-bit PIO (inl/outl) accesses or a single 64-bit MMIO
> (readq/writeq). On other 64-bit architectures, they are always split
> into 32-bit accesses.
>
> Depending on which header gets included in a driver, there are
> additionally definitions for ioread64()/iowrite64() that are
> expected to produce a 64-bit register MMIO access on all 64-bit
> architectures.
>
> To separate the conflicting definitions, make the version in
> include/linux/io-64-nonatomic-*.h visible on all architectures
> but pick the one from lib/iomap.c on architectures that set
> CONFIG_GENERIC_IOMAP in place of the default fallback.
Thanks, this is good to go in my opinion,
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-02-27 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 14:19 [PATCH] asm-generic/io.h: rework split ioread64/iowrite64 helpers Arnd Bergmann
2025-02-27 15:20 ` Andy Shevchenko [this message]
2025-02-27 16:50 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8CCrqzCfwzIpJ-3@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox