From: Wei Liu <wei.liu@kernel.org>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>
Cc: "longli@linuxonhyperv.com" <longli@linuxonhyperv.com>,
KY Srinivasan <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
Arnd Bergmann <arnd@arndb.de>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Long Li <longli@microsoft.com>
Subject: Re: [PATCH v2] Drivers: hv: move panic report code from vmbus to hv early init code
Date: Tue, 18 Apr 2023 18:32:47 +0000 [thread overview]
Message-ID: <ZD7iT/+Uil3jTuNO@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <ZD2dxHaq8NDzpfYw@liuwe-devbox-debian-v2>
On Mon, Apr 17, 2023 at 07:28:04PM +0000, Wei Liu wrote:
> On Sat, Apr 15, 2023 at 06:16:11PM +0000, Michael Kelley (LINUX) wrote:
> > From: longli@linuxonhyperv.com <longli@linuxonhyperv.com> Sent: Thursday, April 13, 2023 6:27 PM
> > >
> > > The panic reporting code was added in commit 81b18bce48af
> > > ("Drivers: HV: Send one page worth of kmsg dump over Hyper-V during panic")
> > >
> > > It was added to the vmbus driver. The panic reporting has no dependence
> > > on vmbus, and can be enabled at an earlier boot time when Hyper-V is
> > > initialized.
> > >
> > > This patch moves the panic reporting code out of vmbus. There is no
> > > functionality changes. During moving, also refactored some cleanup
> > > functions into hv_kmsg_dump_unregister(), and removed unused function
> > > hv_alloc_hyperv_page().
> > >
> > > Signed-off-by: Long Li <longli@microsoft.com>
> > > ---
> > >
> > > Change log v2:
> > > 1. Check on hv_is_isolation_supported() before reporting crash dump
> > > 2. Remove hyperv_report_reg(), inline the check condition instead
> > > 3. Remove the test NULL on hv_panic_page when freeing it
> > >
> > > drivers/hv/hv.c | 36 ------
> > > drivers/hv/hv_common.c | 229 +++++++++++++++++++++++++++++++++
> > > drivers/hv/vmbus_drv.c | 199 ----------------------------
> > > include/asm-generic/mshyperv.h | 1 -
> > > 4 files changed, 229 insertions(+), 236 deletions(-)
> >
> > Reviewed-by: Michael Kelley <mikelley@microsoft.com>
>
> Applied to hyperv-next. Thanks.
This broke allmodconfig. I've removed it from the tree. Please fix and
resend.
Thanks,
Wei.
next prev parent reply other threads:[~2023-04-18 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-14 1:26 [PATCH v2] Drivers: hv: move panic report code from vmbus to hv early init code longli
2023-04-15 18:16 ` Michael Kelley (LINUX)
2023-04-17 19:28 ` Wei Liu
2023-04-18 18:32 ` Wei Liu [this message]
2023-04-19 20:45 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZD7iT/+Uil3jTuNO@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=arnd@arndb.de \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@linuxonhyperv.com \
--cc=longli@microsoft.com \
--cc=mikelley@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).