From: Jisheng Zhang <jszhang@kernel.org>
To: Conor Dooley <conor.dooley@microchip.com>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>, Arnd Bergmann <arnd@arndb.de>,
linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/4] riscv: vmlinux-xip.lds.S: remove .alternative section
Date: Fri, 12 May 2023 23:36:32 +0800 [thread overview]
Message-ID: <ZF5dAG1XZoWA1Om2@xhacker> (raw)
In-Reply-To: <20230512-lunar-overbook-e34b468dda65@wendy>
On Fri, May 12, 2023 at 02:51:56PM +0100, Conor Dooley wrote:
> On Thu, May 11, 2023 at 10:12:08PM +0800, Jisheng Zhang wrote:
> > ALTERNATIVE mechanism can't work on XIP, and this is also reflected by
> > below Kconfig dependency:
> >
> > RISCV_ALTERNATIVE
> > ...
> > depends on !XIP_KERNEL
> > ...
> >
> > So there's no .alternative section at all for XIP case, remove it.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
>
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> Just to note, this series doesn't apply on top of -rc1 - what is the
> base that you used?
rc1 + Palmer's fix branch
Thanks
>
> Cheers,
> Conor.
>
> > ---
> > arch/riscv/kernel/vmlinux-xip.lds.S | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/arch/riscv/kernel/vmlinux-xip.lds.S b/arch/riscv/kernel/vmlinux-xip.lds.S
> > index eab9edc3b631..50767647fbc6 100644
> > --- a/arch/riscv/kernel/vmlinux-xip.lds.S
> > +++ b/arch/riscv/kernel/vmlinux-xip.lds.S
> > @@ -98,12 +98,6 @@ SECTIONS
> > __soc_builtin_dtb_table_end = .;
> > }
> >
> > - . = ALIGN(8);
> > - .alternative : {
> > - __alt_start = .;
> > - *(.alternative)
> > - __alt_end = .;
> > - }
> > __init_end = .;
> >
> > . = ALIGN(16);
> > --
> > 2.40.1
> >
next prev parent reply other threads:[~2023-05-12 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 14:12 [PATCH 0/4] riscv: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION Jisheng Zhang
2023-05-11 14:12 ` [PATCH 1/4] riscv: vmlinux-xip.lds.S: remove .alternative section Jisheng Zhang
2023-05-12 13:51 ` Conor Dooley
2023-05-12 15:36 ` Jisheng Zhang [this message]
2023-05-11 14:12 ` [PATCH 2/4] riscv: move HAVE_RETHOOK to keep entries sorted Jisheng Zhang
2023-05-12 13:54 ` Conor Dooley
2023-05-11 14:12 ` [PATCH 3/4] vmlinux.lds.h: use correct .init.data.* section name Jisheng Zhang
2023-06-01 4:58 ` Guo Ren
2023-05-11 14:12 ` [PATCH 4/4] riscv: enable HAVE_LD_DEAD_CODE_DATA_ELIMINATION Jisheng Zhang
2023-05-12 13:58 ` Conor Dooley
2023-05-12 15:16 ` Conor Dooley
2023-05-12 15:39 ` Jisheng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZF5dAG1XZoWA1Om2@xhacker \
--to=jszhang@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=conor.dooley@microchip.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).