From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4380AC7EE2A for ; Wed, 17 May 2023 06:36:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbjEQGg2 (ORCPT ); Wed, 17 May 2023 02:36:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbjEQGg1 (ORCPT ); Wed, 17 May 2023 02:36:27 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3444A30F7; Tue, 16 May 2023 23:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LyqwcPubn/JsQWHMskCZBu9QXpuNcB4Hd4xqTmLITsI=; b=eXV2qErwJTXGUoa1Zbhw+gAMw0 GNVHvOiLHyJvuf62zEKGLEA9V8ORQo+Sl4BroKuAAfHbtj60Yeb1thb73fA2jXbgVOS2ahCdFJ+mE VBGPhrJlsTqEaUImKwoyge6oq6QxZSdBip10g6F8tqeDJ8i4+J6TKcBSzLDjh/O0ycop+SMQM+F2v ErLvWCCNmc0jDBcTsP3bs2DxNwF3y7u5/NtB9tkK7QEbMxlbzu7B1mE1w0hKm9KQZ8AhgR3r9IIZ6 Qq0G6b9ARjq5usIYdVJksLo3TS+jsz7aBPqlrnsXxU/iw0KvWkX9m2CiMY0l9RQBar9wTFPyr8Blg ptop//Zg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAlr-008UZj-2Q; Wed, 17 May 2023 06:36:23 +0000 Date: Tue, 16 May 2023 23:36:23 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v5 RESEND 10/17] s390: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-11-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-11-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Mon, May 15, 2023 at 05:08:41PM +0800, Baoquan He wrote: > +#define ioremap_wc(addr, size) \ > + ioremap_prot((addr), (size), pgprot_val(pgprot_writecombine(PAGE_KERNEL))) I'd move this out of line and just apply mio_wb_bit_mask directly instead of the unbox/box/unbox/box dance. > +#define ioremap_wt(addr, size) \ > + ioremap_prot((addr), (size), pgprot_val(pgprot_writethrough(PAGE_KERNEL))) and just define this to ioremap_wc. Note that defining _wt to _wc is very odd and seems wrong, but comes from the existing code. Maybe the s390 maintainers can chime on on the background and we can add a comment while we're at it. Otherwise looks good: Reviewed-by: Christoph Hellwig