From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0E0CC7EE23 for ; Wed, 17 May 2023 06:33:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232593AbjEQGdK (ORCPT ); Wed, 17 May 2023 02:33:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232499AbjEQGdI (ORCPT ); Wed, 17 May 2023 02:33:08 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26440359E; Tue, 16 May 2023 23:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mxkdlDqyUpwq2T00umhrhBcnqh9XBG0TKSm9fXSA9Sc=; b=IzlvxhjbxQwrfiXgp7vofG8iRA 3rSVv47naGjy5yBlsCXmBFo0P9BGl4m1f0VVw4LUzJnErB+de4aK+BFgWRpTGgdC4pfm/uFJU4Dlh 0Hu2ZymcFCRd9WHxlZ9qMDbIkfui0s2xxNNgaMTvS1EOChnS3j0ixKLfKexwHyMQbwk2/PSpSYaFw dauSVuDbeVqiWqwt085XxovPwY4LfcOIsv/SzWhAet5ERSxhPfBArznjMkhzGygvFOtQ0pFWACOPi ZLXtnKcURHR5uJ9LY1DjW4ebmWgvjd2dqeHyU5e4JsXgDfiPBeE8OfnOOqPJnq68B3CqfQtNEiZVQ JSzI/lOQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzAig-008Tw8-0Q; Wed, 17 May 2023 06:33:06 +0000 Date: Tue, 16 May 2023 23:33:06 -0700 From: Christoph Hellwig To: Baoquan He Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, hch@infradead.org, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de, linux-ia64@vger.kernel.org Subject: Re: [PATCH v5 RESEND 08/17] ia64: mm: Convert to GENERIC_IOREMAP Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-9-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230515090848.833045-9-bhe@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org > +#define ioremap_prot ioremap_prot > +#define ioremap_cache ioremap > #define ioremap_uc ioremap_uc > #define iounmap iounmap Same comment about the placement here, I'm not going to repeat it if it shows up in more patches. Otherwise looks good: Reviewed-by: Christoph Hellwig