From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46497C77B7E for ; Thu, 1 Jun 2023 11:13:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbjFALNX (ORCPT ); Thu, 1 Jun 2023 07:13:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33284 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbjFALNW (ORCPT ); Thu, 1 Jun 2023 07:13:22 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D48111F; Thu, 1 Jun 2023 04:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8vMskHhtUuRlMIt2Ncz0GeUAC2vyDx9pgosUjZg/dMk=; b=EE58CAOmZjgyHlXe6PwbCLYrPE +9I426e7goRJX287noW4a2DkzzDotI4J1/O5HyeG2E1WS+RJr5xIOL6vqV3cmn4C7XUe8D336Zt3U Ar4YX+z/WnxLDQHHzLpm3dcbeOkXEqBp2frmsTcmCU9Xr7l7GI6n+O4I0hZpoqr6COQA9VBmVdGvG yc2+LWklZABDo76ncn4l6Jxjqy1VUa51l+ztFaYrTUyTtDXwbQpUf4wrmjbbBlmafhds2u0X91rMg oR7WhMsQV9Cn4Ds8RF42U18nYrB+7sHNghT1E2nmQjY9wU0uCs1Jl1Tzap2NBht27gmwWlJxvpA88 a7euVC5A==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1q4gF3-003CdT-0T; Thu, 01 Jun 2023 11:13:17 +0000 Date: Thu, 1 Jun 2023 04:13:17 -0700 From: Christoph Hellwig To: Baoquan He Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, arnd@arndb.de, christophe.leroy@csgroup.eu, agordeev@linux.ibm.com, wangkefeng.wang@huawei.com, schnelle@linux.ibm.com, David.Laight@aculab.com, shorne@gmail.com, willy@infradead.org, deller@gmx.de Subject: Re: [PATCH v5 RESEND 14/17] mm/ioremap: Consider IOREMAP space in generic ioremap Message-ID: References: <20230515090848.833045-1-bhe@redhat.com> <20230515090848.833045-15-bhe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Tue, May 30, 2023 at 05:37:23PM +0800, Baoquan He wrote: > If we want to consolidate code, we can move is_ioremap_addr() to > include/linux/mm.h libe below. Not sure if it's fine. With it, > both kernel/iomem.c and mm/ioremap.c can use is_ioremap_addr(). Can we just add a ne header for this given that no one else really needs it?