From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/3] mips: remove unneeded #include <asm/export.h>
Date: Tue, 15 Aug 2023 10:26:48 +0200 [thread overview]
Message-ID: <ZNs2yBOYr57Rjq9t@alpha.franken.de> (raw)
In-Reply-To: <20230807153243.996262-1-masahiroy@kernel.org>
On Tue, Aug 08, 2023 at 12:32:41AM +0900, Masahiro Yamada wrote:
> There is no EXPORT_SYMBOL line there, hence #include <asm/export.h>
> is unneeded.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> arch/mips/kernel/octeon_switch.S | 1 -
> arch/mips/kernel/r2300_switch.S | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/arch/mips/kernel/octeon_switch.S b/arch/mips/kernel/octeon_switch.S
> index 9b7c8ab6f08c..447a3ea14aa1 100644
> --- a/arch/mips/kernel/octeon_switch.S
> +++ b/arch/mips/kernel/octeon_switch.S
> @@ -11,7 +11,6 @@
> * written by Carsten Langgaard, carstenl@mips.com
> */
> #include <asm/asm.h>
> -#include <asm/export.h>
> #include <asm/asm-offsets.h>
> #include <asm/mipsregs.h>
> #include <asm/regdef.h>
> diff --git a/arch/mips/kernel/r2300_switch.S b/arch/mips/kernel/r2300_switch.S
> index 71b1aafae1bb..48e63943e6f7 100644
> --- a/arch/mips/kernel/r2300_switch.S
> +++ b/arch/mips/kernel/r2300_switch.S
> @@ -13,7 +13,6 @@
> */
> #include <asm/asm.h>
> #include <asm/cachectl.h>
> -#include <asm/export.h>
> #include <asm/fpregdef.h>
> #include <asm/mipsregs.h>
> #include <asm/asm-offsets.h>
> --
> 2.39.2
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2023-08-15 9:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 15:32 [PATCH 1/3] mips: remove unneeded #include <asm/export.h> Masahiro Yamada
2023-08-07 15:32 ` [PATCH 2/3] mips: replace #include <asm/export.h> with #include <linux/export.h> Masahiro Yamada
2023-08-08 9:38 ` Philippe Mathieu-Daudé
2023-08-15 8:27 ` Thomas Bogendoerfer
2023-08-07 15:32 ` [PATCH 3/3] mips: remove <asm/export.h> Masahiro Yamada
2023-08-08 9:39 ` Philippe Mathieu-Daudé
2023-08-15 8:27 ` Thomas Bogendoerfer
2023-08-08 9:37 ` [PATCH 1/3] mips: remove unneeded #include <asm/export.h> Philippe Mathieu-Daudé
2023-08-15 8:26 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNs2yBOYr57Rjq9t@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox