Re: [PATCH 11/11] arm64: dts: rp1: Add support for MACB contained in RP1

Florian Fainelli
2024-08-21T17:02:45Z

On 8/20/24 07:36, Andrea della Porta wrote:
> RaspberryPi RP1 is multi function PCI endpoint device that
> exposes several subperipherals via PCI BAR.
> Add an ethernet node for Cadence MACB to the RP1 dtso
>
> Signed-off-by: Andrea della Porta <andrea.porta@suse.com>
> ---
> arch/arm64/boot/dts/broadcom/rp1.dtso | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/broadcom/rp1.dtso b/arch/arm64/boot/dts/broadcom/rp1.dtso
> index d80178a278ee..b40e203c28d5 100644
> --- a/arch/arm64/boot/dts/broadcom/rp1.dtso
> +++ b/arch/arm64/boot/dts/broadcom/rp1.dtso
> @@ -78,6 +78,29 @@ rp1_clocks: clocks@c040018000 {
> <50000000>; // RP1_CLK_ETH_TSU
> };
>
> + rp1_eth: ethernet@c040100000 {
> + reg = <0xc0 0x40100000 0x0 0x4000>;
> + compatible = "cdns,macb";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + interrupts = <RP1_INT_ETH IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&macb_pclk &macb_hclk &rp1_clocks RP1_CLK_ETH_TSU>;
> + clock-names = "pclk", "hclk", "tsu_clk";
> + phy-mode = "rgmii-id";
> + cdns,aw2w-max-pipe = /bits/ 8 <8>;
> + cdns,ar2r-max-pipe = /bits/ 8 <8>;
> + cdns,use-aw2b-fill;
> + local-mac-address = [00 00 00 00 00 00];
> + phy-handle = <&phy1>;
> + phy-reset-gpios = <&rp1_gpio 32 GPIO_ACTIVE_LOW>;
> + phy-reset-duration = <5>;
> +
> + phy1: ethernet-phy@1 {
> + reg = <0x1>;
> + brcm,powerdown-enable;

Undocumented property, and I would like to understand why this needs to
be specified in the Device Tree? What model of Broadcom Ethernet PHY is
being used here?
--
Florian