From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C1281C330D for ; Mon, 2 Sep 2024 09:21:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725268898; cv=none; b=b9sSY/eqHtZqtypwrnN7sPDNztAbgp44mFx1udwX8XH/uta2+aVvv0VCu3drc+ga6zq7MrPaKSiQbhLYC3e7ROEzKdpxxKzKclmapJVo66pOazLwsMNJiqkWxAj1QK3JpJ8JxHyECst/Wd0uzb4tagbwEwKYkHUxfOm2uSxdMIs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725268898; c=relaxed/simple; bh=BSpqubEdJ/sRUU6vWaBwncVg7qOd28rdyPPZgAweRno=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oyyrPSz+kiigdl9pkqNXoKaK3AE9xjPC3kEMZPc5I6Jmm4pOFyTHSUwRM3L0VzWRi1/bThlimD9nq/hQHIamRp7MPMOYG2ETNToqoPNheHido+FqB3Q9GiGc5L+vbdjVjGmPUTCozHaNXFojFXLW+p9wXCfkc22xzExy+ZryMqk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=UA7k4zL2; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="UA7k4zL2" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a86e5e9ff05so468761466b.1 for ; Mon, 02 Sep 2024 02:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725268894; x=1725873694; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=1ZDs/9l3dOZ4/JRpcNDnT31Gwsua2/3rtLsltEu9Mww=; b=UA7k4zL27EtQiyL1sHrgRCfTMPBXKeFmHxdZe3ebhOMpjrG/LvCIEKtNXE/wR+fdC0 nGc8eVPdONCBPfmOl9gVV5Fv0lB3hSjTq0u7jK/66YtY2pXMeS7fTFAN/VGpzWJRkzbn XkzYzfEsazl03MK/eExlEnIgkIx/NmtK0yvuqYc+fGv4VEIvD6oZ63hEUR6e55d0Th+H ragU4vi9H2cqQqxMviFP196JUbdigDpKSrLJLnTZGWB3zija/D7YC9Eh6CtjA96jSPtL GZudEXjpOBEz/hjpIjWhdIeragV3oITHm659ApbXz3h2is871vprXeJBwVBuOXrAGPUJ LX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725268894; x=1725873694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1ZDs/9l3dOZ4/JRpcNDnT31Gwsua2/3rtLsltEu9Mww=; b=Mu1fMyBQjtm/3yA/ZytaISIiGoUAxnAyvihTUpfkDCoggI/x1AN7/6N3mn9m4/+JCk h1O+7WtMY+jb9Qi+63GzSKiBNDLH54pQGVPO2txYhHGX8oVIh2M/QosGsDHRjBB+q3R6 ozPzflVjiJPV4LLUoZuYx5JBCHILTTDPIYLQ14RdaklN2sAv/Y4GfZ4CZxWPPk/xtLqr y9qkiTh2HWBoGlLdT9ZelBDOkA/GtSG6JthRFVNwSzkMbm1/OEVbG8sj9dWjN7r6i0/y E4upE315BJhCujVmgyxiWHT2SFeN9ocYFViCyCyuCeGL+PwpXU1ileRvsKycmZ5rIiwo brlg== X-Forwarded-Encrypted: i=1; AJvYcCVYtoj2YwnfpR5h8NKL5iMGxW1Lj8n1TdbCJfOEIk1EpC80GCWU7DsSiCMc3Mt6k5vAcjmjtvFAORLU@vger.kernel.org X-Gm-Message-State: AOJu0Yz7rqxQ/XLBmdWxbm0Dixsmy0WxiMAB2M0KMc6gPw4arC9uecGK HE+31suumrsOu+gDHLkNhEqvuV7mj6DUkD9yrf3VnSvxTNERzRk8DWlm2cqG6e8= X-Google-Smtp-Source: AGHT+IFiJyKI83M4pAEH+bJt4D+2x9ZKVCIWaumLPxOS3x0JckDJtyYxve6HAvVZNlN6e2kKZafDDw== X-Received: by 2002:a17:907:6094:b0:a7a:adac:57d5 with SMTP id a640c23a62f3a-a897f84d7efmr930072566b.18.1725268894023; Mon, 02 Sep 2024 02:21:34 -0700 (PDT) Received: from localhost (host-80-182-198-72.retail.telecomitalia.it. [80.182.198.72]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891db42fsm527788266b.184.2024.09.02.02.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 02:21:33 -0700 (PDT) From: Andrea della Porta X-Google-Original-From: Andrea della Porta Date: Mon, 2 Sep 2024 11:21:41 +0200 To: Andrew Lunn Cc: Andrea della Porta , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Linus Walleij , Catalin Marinas , Will Deacon , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Nicolas Ferre , Claudiu Beznea , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Saravana Kannan , Bjorn Helgaas , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, Lee Jones , Stefan Wahren Subject: Re: [PATCH 00/11] Add support for RaspberryPi RP1 PCI device using a DT overlay Message-ID: References: <14990d25-40a2-46c0-bf94-25800f379a30@kernel.org> <45a41ed9-2e42-4fd5-a1d5-35de93ce0512@lunn.ch> <334b382a-c9ab-47e4-b860-b8477f04c3fb@lunn.ch> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <334b382a-c9ab-47e4-b860-b8477f04c3fb@lunn.ch> Hi Andrew, On 16:10 Fri 30 Aug , Andrew Lunn wrote: > > On a second thought, are you really sure we want to proceed with the header file? > > After all the only line in it would be the extern declaration and the only one to > > include it would be rp1-dev.c. Moreover, an header file would convey the false > > premise that you can include it and use that symbol while in fact it should be > > only used inside the driver. > > OTOH, not creating that header file will continue to trigger the warning... > > The header file does not need to be in global scope. It could be in > the driver source directory. As such, nothing outside of the driver > can use it. Ack. > > Headers like this have multiple proposes. One is they make a symbol > visible to the linker. But having two different .c files include the Hmm... not sure what second file is including it, since only rp1_pci.c needs it. > header enables type checking, which for long term maintenance is just > as important. So a one line header is fine. Done. Cheers, Andrea > > Andrew >