From: Paul Moore <paul@paul-moore.com>
To: Ricardo Robaina <rrobaina@redhat.com>,
audit@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arch@vger.kernel.org
Cc: eparis@redhat.com, arnd@arndb.de, sgrubb@redhat.com,
Ricardo Robaina <rrobaina@redhat.com>
Subject: Re: [PATCH v2] audit: add missing syscalls to PERM class tables
Date: Tue, 30 Jun 2026 15:58:28 -0400 [thread overview]
Message-ID: <a12cfd8a21c2b8a51302a28e05c924ba@paul-moore.com> (raw)
In-Reply-To: <20260612141436.3137694-1-rrobaina@redhat.com>
On Jun 12, 2026 Ricardo Robaina <rrobaina@redhat.com> wrote:
>
> Add missing file metadata syscalls to the audit PERM class tables,
> addressing gaps where certain file operations were not properly
> classified for audit rule matching.
>
> Changes:
> - audit_change_attr.h: Add file_setattr
>
> - audit_read.h: Add quotactl_fd, file_getattr, stat, stat64, lstat,
> lstat64, fstat, fstat64, newfstatat, fstatat64, and statx
>
> - audit_write.h: Add quotactl_fd
>
> Architecture-specific and conditionally-compiled syscalls are guarded
> with #ifdef.
>
> Signed-off-by: Steve Grubb <sgrubb@redhat.com>
> Signed-off-by: Ricardo Robaina <rrobaina@redhat.com>
> ---
> Changes in v2:
> - Added stat64 family syscalls (stat64, lstat64, fstat64, fstatat64) to
> audit_read.h for 32-bit architecture support.
> - Dropped timestamp-related syscalls (utime, utimes, utimensat, etc.)
> due to potential audit log volume increase impact. Those will be
> addressed in a separate patch after closer investigation.
>
> include/asm-generic/audit_change_attr.h | 3 +++
> include/asm-generic/audit_read.h | 31 +++++++++++++++++++++++++
> include/asm-generic/audit_write.h | 3 +++
> 3 files changed, 37 insertions(+)
Looks good to me, merged into audit/dev, thanks.
--
paul-moore.com
prev parent reply other threads:[~2026-06-30 19:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-12 14:14 [PATCH v2] audit: add missing syscalls to PERM class tables Ricardo Robaina
2026-06-30 19:58 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a12cfd8a21c2b8a51302a28e05c924ba@paul-moore.com \
--to=paul@paul-moore.com \
--cc=arnd@arndb.de \
--cc=audit@vger.kernel.org \
--cc=eparis@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrobaina@redhat.com \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox