Re: [PATCH v6 2/9] rust: sync: Add basic atomic operation mapping framework

Boqun Feng
2025-07-10T20:29:34Z

On Thu, Jul 10, 2025 at 09:21:17PM +0200, Benno Lossin wrote:
> On Thu Jul 10, 2025 at 6:16 PM CEST, Boqun Feng wrote:
> > At least the rustdoc has safety section for each function. ;-)
>
> I don't usually use rustdoc to read function safety sections. Instead I
> jump to their definition and read the code.
>

Understood. It's probalby the first time we use macros to generate a few
unsafe functions, so this is something new.

But let me ask you a question, as a programmer yourself, when you run
into a code base, and see something repeat in a similar pattern for 10+
times, what's your instinct? You would try to combine the them together,
right? That's why duplication seems not compelling to me. But surely, we
don't need to draw conclusion right now, however that's my opinion.

Regards,
Boqun

> ---
> Cheers,
> Benno