Re: [PATCH v1 2/3] rust: sync: atomic: Remove workaround macro for i8/i16 BasicOps

[Boqun Feng <boqun.feng@gmail.com>]

On Mon, Dec 29, 2025 at 09:55:58PM +0900, FUJITA Tomonori wrote:
> On Mon, 29 Dec 2025 19:58:48 +0800
> Boqun Feng <boqun.feng@gmail.com> wrote:
> 
> > On Sun, Dec 28, 2025 at 09:05:45PM +0900, FUJITA Tomonori wrote:
> >> Remove workaround impl_atomic_only_load_and_store_ops macro and use
> >> declare_and_impl_atomic_methods to add AtomicBasicOps support for
> >> i8/i16.
> >> 
> > 
> > I did the following so that we can drop this ;-)
> > 
> > 1. Change function names of [1] and [2] from *{load,store}* to
> >    *{read,set}*.
> > 
> > 2. Reorder [3] before [4] to avoid introduction of
> >    impl_atomic_only_load_and_store_ops!()
> > 
> > [1]: https://lore.kernel.org/all/20251211113826.1299077-3-fujita.tomonori@gmail.com/
> > [2]: https://lore.kernel.org/all/20251211113826.1299077-2-fujita.tomonori@gmail.com/
> > [3]: https://lore.kernel.org/all/20251228120546.1602275-2-fujita.tomonori@gmail.com/
> > [4]: https://lore.kernel.org/all/20251211113826.1299077-4-fujita.tomonori@gmail.com/
> > 
> > I also reorder a bit to make the introduction of helpers are grouped
> > together, please see at
> > 
> > 	https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/log/?h=rust-sync.20251229
> > 
> > I feel this way we have a cleaner history of changes.
> 
> It looks much cleaner now, thanks!
> 
> Maybe, you could consider chan ging the following two points:
> 
> - change the first patch subject
> 
> rust: helpers: Add i8/i16 atomic_read_acquire/atomic_set_release helpers 
> 
> - drop the following comment in 12th patch:
> 
> +// It is still unclear whether i8/i16 atomics will eventually support
> +// the same set of operations as i32/i64, because some architectures
> +// do not provide hardware support for the required atomic primitives.
> +// Furthermore, supporting Atomic<bool> will require even more
> +// significant structural changes.
> +//
> +// To avoid premature refactoring, a separate macro for i8 and i16 is
> +// used for now, leaving the existing macros untouched until the overall
> +// design requirements are settled.
> 
Good eyes!

Done (along with other fixes):

	https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/log/?h=rust-sync.20251229b

Regards,
Boqun