From: Roland Dreier <rdreier@cisco.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
Roland Dreier <rolandd@cisco.com>
Subject: Re: [PATCH 11/37] infiniband: use get/put_endian helpers
Date: Thu, 29 May 2008 22:52:11 -0700 [thread overview]
Message-ID: <ada1w3knxtg.fsf@cisco.com> (raw)
In-Reply-To: <1212099859.28403.149.camel@brick> (Harvey Harrison's message of "Thu, 29 May 2008 15:24:19 -0700")
> Well, assuming it's wanted, I can send you a sed-based patch instead and
> a follow-on patch that does the additional codingstyle bits on the
> changed lines that adds up to this patch.
If you generated the patch with sed + careful codingstyle fixup, that's
OK, no need to resend.
I think the big question is whether this change is worth it -- my
immediate reaction is that it is just churn, but I am only seeing one of
the 37 (?!) patches in the series so maybe there is some merit that I am
unaware of. Anyway I am happy with whatever Andrew decides based on his
view of the big picture.
- R.
prev parent reply other threads:[~2008-05-30 5:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 20:18 [PATCH 11/37] infiniband: use get/put_endian helpers Harvey Harrison
2008-05-29 22:19 ` Roland Dreier
2008-05-29 22:24 ` Harvey Harrison
2008-05-30 5:52 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ada1w3knxtg.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox