From: Roland Dreier <rdreier@cisco.com>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
torvalds@osdl.org
Subject: Re: [PATCH 2/7] severing fs.h, radix-tree.h -> sched.h
Date: Mon, 30 Oct 2006 08:47:44 -0800 [thread overview]
Message-ID: <adak62hyclr.fsf@cisco.com> (raw)
In-Reply-To: <E1GeUeF-0002o7-6s@ZenIV.linux.org.uk> (Al Viro's message of "Mon, 30 Oct 2006 10:45:43 +0000")
Trivial comment:
> /*
> + * Superblock locking. We really ought to get rid of these two.
> + */
> +void lock_super(struct super_block * sb)
> +{
> + get_fs_excl();
> + mutex_lock(&sb->s_lock);
> +}
> +
> +void unlock_super(struct super_block * sb)
> +{
> + put_fs_excl();
> + mutex_unlock(&sb->s_lock);
> +}
> +
> +EXPORT_SYMBOL(lock_super);
> +EXPORT_SYMBOL(unlock_super);
isn't the current fashion to do this like:
void lock_super(struct super_block * sb)
{
get_fs_excl();
mutex_lock(&sb->s_lock);
}
EXPORT_SYMBOL(lock_super);
void unlock_super(struct super_block * sb)
{
put_fs_excl();
mutex_unlock(&sb->s_lock);
}
EXPORT_SYMBOL(unlock_super);
next prev parent reply other threads:[~2006-10-30 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 10:45 [PATCH 2/7] severing fs.h, radix-tree.h -> sched.h Al Viro
2006-10-30 16:47 ` Roland Dreier [this message]
2006-10-31 8:04 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adak62hyclr.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox