From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6BD0114A4F0; Tue, 28 Apr 2026 23:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=13.77.154.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777418909; cv=none; b=ZUHUW2AmO0CnB15CWO47TQIuapHqxAZfYFds9e+L5Ed76DhbF77o/QKwFu143YNn8hkKhlCouelbkTyP6PwQ8fJLjEQqHZcGLzYZdrPtD1Kav29YNYW3bfCMzX1AzrI7u6BZK/9HvdulQMK2nbQnv6JCju4hEp6XuFVnogAd7qI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777418909; c=relaxed/simple; bh=7PLMpsYyH2G9ayi4bZrO8oMZmYgVLiuqewZ9TXY0H84=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VeDSMthHtqtLJWRMeoP02JCNIYxERAnWctVkMrVLEVaqDFeIhqzqA8H0F2AIx3/q+hyVZgfqneZHuK90LpcR8NOZrJX/vxMQKfgNZzY1Wo4j+j4Wh5ms+zkKG6N86QO6kPizuq1ZTLJBLs9SpS0er9a91BzUUYbjJbDihrekBBE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b=itfDduy+; arc=none smtp.client-ip=13.77.154.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="itfDduy+" Received: from skinsburskii.localdomain (unknown [20.236.10.163]) by linux.microsoft.com (Postfix) with ESMTPSA id 135C320B716F; Tue, 28 Apr 2026 16:28:28 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 135C320B716F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1777418908; bh=8Li2V8V7QxN30Y7Y7+L1qUmWTDNPZ5YHsj5L+dhyldg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=itfDduy+hYQbMgttqIqztMVkyn3ncrBUWLFrH7+Q/yuHQ/oaJKK29o1wH+92PyXvd 1A56GVxcMVuDFwK8OH90BajUk5CWD50LgQiM6U9W7HsR0UCwRhJaweioaKtoDvR8Ku Mwt2eMCiVUDroLtPXYQveyK4UYHajeFR4Me1GN0A= Date: Tue, 28 Apr 2026 16:28:25 -0700 From: Stanislav Kinsburskii To: Jork Loeser Cc: linux-hyperv@vger.kernel.org, x86@kernel.org, "K . Y . Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Arnd Bergmann , Michael Kelley , Anirudh Rayabharam , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH v4 2/3] mshv: clean up SynIC state on kexec for L1VH Message-ID: References: <20260427213855.1675044-1-jloeser@linux.microsoft.com> <20260427213855.1675044-3-jloeser@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260427213855.1675044-3-jloeser@linux.microsoft.com> On Mon, Apr 27, 2026 at 02:38:53PM -0700, Jork Loeser wrote: > The reboot notifier that tears down the SynIC cpuhp state guards the > cleanup with hv_root_partition(), so on L1VH (where > hv_root_partition() is false) SINT0, SINT5, and SIRBP are never > cleaned up before kexec. The kexec'd kernel then inherits stale > unmasked SINTs and an enabled SIRBP pointing to freed memory. > > Remove the hv_root_partition() guard so the cleanup runs for all > parent partitions. > > Signed-off-by: Jork Loeser Reviewed-by: Stanislav Kinsburskii > --- > drivers/hv/mshv_synic.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/hv/mshv_synic.c b/drivers/hv/mshv_synic.c > index 2db3b0192eac..978a1cace341 100644 > --- a/drivers/hv/mshv_synic.c > +++ b/drivers/hv/mshv_synic.c > @@ -723,9 +723,6 @@ mshv_unregister_doorbell(u64 partition_id, int doorbell_portid) > static int mshv_synic_reboot_notify(struct notifier_block *nb, > unsigned long code, void *unused) > { > - if (!hv_root_partition()) > - return 0; > - > cpuhp_remove_state(synic_cpuhp_online); > return 0; > } > -- > 2.43.0 >